1294 categories for organisations

[dmijatovic]

Categories for organisations

Closes #1294

Changes proposed in this pull request:

• Organisation maintainer can create custom categories to be used by projects and software of the organisation
• Software and project maintainers can select custom categories specific to organisation  
• Organisation categories are shown on software page in the side panel on the left, under the logo
• Organisation categories are shown on project page in the side panel on the left
• Refactored code to reduce code duplication. ~5% is optimal amount in my opinion, otherwise we will need additional level of abstraction which in my opinion will further increase cognitive load.
• Updated user documentation (software,project and organisation pages)

How to test:

• make start to build and generate test data
• navigate to organisations and select first organisation
• login as rsd-admin (first login in dev mode)
• navigate to organisation settings, categories tab
• add categories to organisation:
  • create project specific categories (use "For projects" switch)
  • create software specific categories
  • create shared categories (check both for software and project switch)
• navigate to software item and add organisation that you just added the categories to
• confirm that categories modal appears and you can assign organisation categories
• select some categories and confirm that these are shown on the software page
• navigate to project item and add organisation that you just added the categories to
• confirm that categories modal appears and you can assign organisation categories
• select some categories and confirm that these are shown on the project page
• bonus test: enable communities in the settings.json and test community categories for software

Example organisation categories

Example adding organisation categories to software or project

Example organisation categories on project page (bottom of side panel)

PR Checklist:

• Increase version numbers in docker-compose.yml
• Link to a GitHub issue
• Update documentation
• Tests

[jmaassen]

I seem to have run into a bug. This are the steps I took

• create an empty RSD
• created an organization "Netherlands eScience Center"
• added category "Calls" with subcategories "ASDI2018, ASDI2020, ETEC2020, KD2019"
• added category "Expertise" with subcategory "Computing" and subsubcategories "GPU, Low power, distributed"
• added to category "Expertise" subcategory "Big data" and subsubcategories "Real time, Heterogeneous"

Next added project:

• test
• organization: "Netherlands eScience Center"
• categories: Calls/ASDI2018, Expertise: Computing/GPU and Big Data/Real Time
• publish project

Project page of "test" looks as expected

Next added another project:

• test2
• organization: "Netherlands eScience Center"
• categories: Calls/ETEC2020, Expertise: Computing/Low Power and Big Data/Heterogeneous
• publish project

Project page of "test2" looks as expected

But the categories of project "test" have now disappeared?

[dmijatovic]

@jmaassen Well spotted! I have fixed bug. The PR is (again) ready for testing.

[ewan-escience]

I will adapt/edit the row level security rules for the tables.

[ewan-escience]

When adding a new non-root category to an organisation, the two switches to enable/disable software and/or projects for this category is visible, untill you type something in one of the input fields.

Otherwise, nice work!

[jmaassen]

During the demo for @bakhshir I ran into an issue with being able to add a category as a organization maintainer. What I did is the following:

• create an empty RSD
• sign in a maintainer
• create an organization for the eScience Center
• create some example categories for the eScience Center
• get a maintainer link for the organization
• log in as a different user
• click the organization maintainer link
• create a project page, select eScience Center as organization, select categories (works fine)
• go to the organization page
• try to add addition category

I then get a error about row level security:

[ewan-escience]

Does that error still happen on the latest changes? I pushed some changes to the row level security earlier today.

[dmijatovic]

@jmaassen I fixed the modal error Ewan noticed. Can you test again?

[jmaassen]

The issue is gone now, and everything works as expected.

[sonarqubecloud]

Quality Gate passed for 'rsd-database'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
14.6% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate failed for 'rsd-frontend'

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud