Backports / 11.2.0-beta.1 #7279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerschmidt
approved these changes
Feb 5, 2025
tsnobip
approved these changes
Feb 5, 2025
| @@ -245,25 +251,30 @@ let scanNumber scanner = | |||
| 8) | |||
| | _ -> 10 | |||
| in | |||
| scanDigits scanner ~base; | |||
| ignore (scanDigits scanner ~base); | |||
There was a problem hiding this comment.
not a big fan of ignore here, it would swallow errors if we add an argument to the function later on
Suggested change
| ignore (scanDigits scanner ~base); | |
| let _foundDigits: bool = scanDigits scanner ~base; |
But it's likely something we should instead fix on master.
There was a problem hiding this comment.
@tsnobip Agreed - would you do a PR on master?
cristianoc
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.