Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not deselect on ESC when it was used to close some other UI element #7548

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Sep 30, 2024

What

This PR attempt to make the "deselect-on-ESC" less aggressive and avoid triggering it when the ESC keystroke was used to close some other UI element.

Work around for:

Supported

  • any popup menu (including color picker)
  • context menu
  • modals

TODO

  • rerun menu (haven't found an easy way yet)

Not supported

  • tooltip (on purpose, these disappear by themselves)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Sep 30, 2024
@abey79 abey79 marked this pull request as ready for review September 30, 2024 08:55
@Wumpf Wumpf self-requested a review September 30, 2024 14:38
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@abey79 abey79 merged commit 6bfb5e8 into main Sep 30, 2024
35 of 37 checks passed
@abey79 abey79 deleted the antoine/escape-to-deselect branch September 30, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants