Introduce ColumnSelector instead of ColumnDescriptor #7444
Conversation
jleibs
added
⛃ re_datastore
jleibs
force-pushed
the
jleibs/column_selectors
branch
from
7a33c41
to
7fc5c90
Compare
| impl From<ControlColumnDescriptor> for ControlColumnSelector { | ||
| fn from(desc: ControlColumnDescriptor) -> Self { | ||
| Self { | ||
| component: desc.component_name, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
A helper for the row id column would be neat here.
There was a problem hiding this comment.
Ha, yeah, I did exactly that in the python APIs.
| pub fn new<C: re_types_core::Component>(entity_path: EntityPath) -> Self { | ||
| Self { | ||
| entity_path, | ||
| component: C::name(), | ||
| join_encoding: JoinEncoding::default(), | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: from my perspective, this is a bit too restrictive an API to deserve the privileged new() name. Oftentimes, I just have a component name (e.g. when deserialising from blueprint).
| pub fn new<C: re_types_core::Component>(entity_path: EntityPath) -> Self { | |
| Self { | |
| entity_path, | |
| component: C::name(), | |
| join_encoding: JoinEncoding::default(), | |
| } | |
| } | |
| pub fn new(entity_path: EntityPath, component: ComponentName) -> Self { | |
| Self { | |
| entity_path, | |
| component, | |
| join_encoding: JoinEncoding::default(), | |
| } | |
| } | |
| pub fn new_for_component<C: re_types_core::Component>(entity_path: EntityPath) -> Self { | |
| Self::new(entity_path, C::name()) | |
| } |
There was a problem hiding this comment.
I think you are practically speaking in the minority of users that would feel restricted here. I think having concrete components is likely to be the more common pattern than dealing with raw ComponentNames.
| archetype_name: None, | ||
| archetype_field_name: None, | ||
| component_name: selector.component, | ||
| store_datatype: ArrowListArray::<i32>::default_datatype(datatype.clone()), |
There was a problem hiding this comment.
Shouldn't that depend on selector.join_encoding?
There was a problem hiding this comment.
Nope. The store_datatype is always a list. join_encoding influences the construction of .returned_datatype()
What
Resolves:
ComponentColumnDescriptorcannot be used as a query input #7365ColumnSelectorto use in query APIs. #7435Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.