Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ndarray to 0.16 and ndarray-rand to 0.15 #7358

Merged
merged 9 commits into from
Sep 20, 2024

Conversation

benliepert
Copy link
Contributor

@benliepert benliepert commented Sep 5, 2024

What

Fixes #7157. I also updated ndarray-rand (sorry if that should be separate - it didn't appear to require any changes).

into_raw_vec() is now into_raw_vec_and_offset().0 (the offset is ignored)

I wasn't sure whether an order (RowMajor vs. ColumnMajor) should be specified in into_shape_with_order(). I ran through all the examples and couldn't find one that actually used this code, so guidance here is appreciated.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@benliepert benliepert marked this pull request as ready for review September 19, 2024 13:08
@emilk emilk added 🦀 Rust API Rust logging API dependencies concerning crates, pip packages etc include in changelog labels Sep 20, 2024
@emilk emilk merged commit e12e809 into rerun-io:main Sep 20, 2024
32 of 34 checks passed
@benliepert benliepert deleted the benliepert/update_ndarray branch September 20, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc include in changelog 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ndarray
2 participants