-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rfd version to 0.14.1. #6795
base: main
Are you sure you want to change the base?
Conversation
Unfortunately this leads to a lot of duplicated dependencies, as you can see by running EDIT: it seems difficult to avoid pulling in |
I think the main problem is that rfd bumped its ashpd version from 0.6 to 0.8 in PolyMeilex/rfd@a88718e which in turn now requires zbus version 4.0. Sadly I couldn't find a way to reconcile the duplicate zbus dependency. But I'm also not really familar with Rust as a whole, maybe I'm just too dumb. EDIT: Nevermind, just saw your edit... Do you have an ETA on when emilk/egui#4437 will make it into egui and in turn into the Python rerun-sdk? |
No ETA on the We could consider living with the duplicated dependencies, but I'm not a big fan of the increased compilation times that will result in. |
No worries, maybe I can figure out a way to get rfd 0.12 with xdg-portal backend working inside my docker container after all. |
I wonder if this PR solves |
an update of winit has now landed on |
looks like accesskit didn't get updated on egui - the zbus dependency hasn't improved when merging, resetting cargo.lock to main and building |
Fixes rfd file-dialogs not opening up inside Docker containers by bumping the rfd version to 0.14.1 which includes a zenity fallback that works inside Docker containers. See #6794 for more info.
What
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.