Orbit eye: bugfixes and usability improvements #3817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🪳 bug
emilk
requested changes
Oct 11, 2023
|
After rolling the up-axis, the next rotation causes a big (non-smooth) jump |
teh-cmc
force-pushed
the
cmc/orbit_eye_fixes
branch
from
d3a9a86
to
fd1a2ec
Compare
teh-cmc
force-pushed
the
cmc/orbit_eye_fixes
branch
from
fd1a2ec
to
09a0b5f
Compare
|
Would be nice to get this in @teh-cmc :) |
Yep I'd love to; it's looking pretty good now, there's just one last math issue left and it goes way beyond my very limited abilities 😶 I'll get someone to help me next week so we can land this! |
|
I wish we could get this in - having a fixed up-axis would really help camera interaction |
5 tasks
|
emilk
added a commit
that referenced
this pull request
Feb 15, 2024
* Continuing the work in #3817 ### What - The orbit eye now always maintains an up axis internally (+Z by default, if there is no `ViewCoordinates`). - When a user rolls the camera (middle mouse drag), we now change the internal up-axis, which makes rolling then orbiting a much better experience as you don't end up in a weird state with no up axis. - The orbit eye center visualization now indicates the current up-axis https://github.com/rerun-io/rerun/assets/1148717/daeb1e57-8fe3-4ac9-84fc-c673bb70ad09 - Fixes #3539 - Fixes #3420 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5193/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5193/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5193/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5193) - [Docs preview](https://rerun.io/preview/c4c8821a33c3df282e31c64ca1d719358666b72a/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/c4c8821a33c3df282e31c64ca1d719358666b72a/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Clement Rey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUBif unspecified.23-10-11_19.11.55.patched.mp4
What
Checklist