-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use deterministic flushing when building web demo .rrd
files
#3064
Conversation
Use proper unit names, and two decimals of precision
The entries saved in GCS use |
let's delete the existing entries then |
I guess the easiest thing is just to delete the old data and start over instead of hacking in support for both somehow |
Co-authored-by: Jan Procházka <[email protected]>
Co-authored-by: Jan Procházka <[email protected]>
Size changes
|
I'm not sure how well the github pages graphs would cope with that |
Oh I see… well let's use |
All we need to do is remove the explicit units set in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works too
What
I saw this in #3063
and spotted several problems:
A) there was nothing in that PR changing the .rrd files
B) the comparison format uses way too many decimals
C) the comparison uses "KB" which isn't a unit
The first problem should be fixed by turning off time-based batch flushing (first commit).
Checklist