Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deterministic flushing when building web demo .rrd files #3064

Merged
merged 8 commits into from
Aug 22, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 22, 2023

What

I saw this in #3063
Screenshot 2023-08-22 at 13 40 24

and spotted several problems:

A) there was nothing in that PR changing the .rrd files
B) the comparison format uses way too many decimals
C) the comparison uses "KB" which isn't a unit

The first problem should be fixed by turning off time-based batch flushing (first commit).

Checklist

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 22, 2023
@emilk emilk requested a review from jprochazk August 22, 2023 11:42
@jprochazk
Copy link
Member

The entries saved in GCS use MB, so comparing against previous entries won't work

@emilk
Copy link
Member Author

emilk commented Aug 22, 2023

let's delete the existing entries then

@jprochazk
Copy link
Member

I guess the easiest thing is just to delete the old data and start over instead of hacking in support for both somehow

scripts/ci/sizes.py Outdated Show resolved Hide resolved
scripts/ci/sizes.py Outdated Show resolved Hide resolved
emilk and others added 2 commits August 22, 2023 15:19
Co-authored-by: Jan Procházka <[email protected]>
Co-authored-by: Jan Procházka <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Size changes

Name Previous Current Change
Wasm (none) 13.5 MiB +100%
JS (none) 107.7 kiB +100%
arkit_scenes.rrd (none) 40.35 MiB +100%
detect_and_track_objects.rrd (none) 55.22 MiB +100%
dicom_mri.rrd (none) 63.36 MiB +100%
dna.rrd (none) 0.62 MiB +100%
human_pose_tracking.rrd (none) 55.58 MiB +100%
plots.rrd (none) 0.19 MiB +100%
structure_from_motion.rrd (none) 6.83 MiB +100%

@emilk
Copy link
Member Author

emilk commented Aug 22, 2023

This is unreadable - why is it using kiB for such large files? I suggest we use bytes in the GCS store and then chose the unit dynamically based on the scale of the value

image

@jprochazk
Copy link
Member

I suggest we use bytes in the GCS store and then chose the unit dynamically based on the scale of the value

I'm not sure how well the github pages graphs would cope with that

@emilk
Copy link
Member Author

emilk commented Aug 22, 2023

Oh I see… well let's use MiB for .rrd files then

@jprochazk
Copy link
Member

why is it using kiB for such large files?

All we need to do is remove the explicit units set in .github/workflows/reusable_track_size.yml

Copy link
Member

@jprochazk jprochazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works too

@emilk emilk merged commit 168c8f5 into main Aug 22, 2023
26 checks passed
@emilk emilk deleted the emilk/deterministic-web-demo branch August 22, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants