Unify AnyValues across all SDKs and use archetype_field_name as discriminator
#10074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
grtlr
added
include in changelog
🚜 refactor
grtlr
force-pushed
the
grtlr/any-values
branch
2 times, most recently
from
d546580 to
b68f3c3
Compare
emilk
reviewed
May 27, 2025
Comment on lines
+17
to
+25
| Arc::new(arrow::array::StringArray::from(vec![ | ||
| "https://www.rerun.io", | ||
| ])), | ||
| ) | ||
| .with_field( | ||
| "repository", | ||
| Arc::new(arrow::array::StringArray::from(vec![ | ||
| "https://github.com/rerun-io/rerun", | ||
| ])), |
There was a problem hiding this comment.
If we use impl Into<ArrayRef> as the argument type, maybe we can get rid of the Arc::new here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
AnyValuesshould use argument names to setarchetype_field_namemetadata #9906.AnyValueswrapper to Rust and C++ APIs #9340.What
This PR does multiple things:
AnyValuesinterface that is similar across Python 🐍 , C++ 🌊 , and Rust 🦀 SDKs (so far we only haveAnyValuesin Python).kwargs(i.e. the name of the field toarchetype_field_nameinstead ofcomponent_name.AnyValueswe ensure that more of the logged data is actually tagged.TODOs