Rename ComponentDescriptor::new to ComponentDescriptor::partial
#10071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
approved these changes
May 26, 2025
| @@ -151,7 +151,7 @@ impl FromIterator<(ComponentName, ArrowListArray)> for ChunkComponents { | |||
| fn from_iter<T: IntoIterator<Item = (ComponentName, ArrowListArray)>>(iter: T) -> Self { | |||
There was a problem hiding this comment.
Do we still use this iterator? Looks like we really shouldn't, please remove or add to list of things to remove for tagged components
|
Thanks! Will merge after we have the new |
|
Superseded by #10082. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
ComponentDescriptorsin Rust SDK #10056.What
Title. Also adds a deprecation note.