Add "pyupgrade" pre-commit hook and auto-format the code accordingly #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWCook
requested changes
Dec 8, 2023
Good point. I was holding off on that until ruff's formatter was out of beta, but this post describes it as "production-ready." I'll give it a try! |
|
No problem! I don't think I've seen that before either. I just manually removed the revert commits, so both of these MRs are in main now. Thanks again for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As a part of work on #164, I added https://github.com/asottile/pyupgrade with the target Python version defined as
3.8.I did make unrelated changes (any Python 3.7 leftovers, if any, should removed in a separate PR).
Breaking changes
No.
User guide, contribution guidelines, changelog update
Not required.
HISTROY.mdalready has a related record: https://github.com/requests-cache/aiohttp-client-cache/blame/main/HISTORY.md#L5I think that the next step is removing Black, Flake8, Isort, pyupgrade because Ruff re-implemented all of them. Similar to requests-cache/requests-cache@83f7bc7 but in that PR you replaced only Flake8.