Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemTests: avoid unneeded assemblies copies in Testprojects #311

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

obligaron
Copy link
Contributor

What's changed?

This PR reduces the number of assemblies copied to the bin directory by the TestProjectGenerator in the system tests. This happens because

  • Fewer nuget packages are referenced
  • Satellite assemblies are not copied

This reduces the bin directory size of a typical test project from 4.91 MB (98 files) to 2.46 MB (28 files).

⚡️ What's your motivation?

To improve system test execution time and reduce test project dependencies (and therefore complexity).
Interestingly, on my machine, the execution time didn't change that much. But I still think the change is a win because we have less I/O and the generated projects have fewer dependencies to maintain and understand.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

I have checked that all tests run successfully on my local machine and on CI. But I'm not sure if all the tests run on CI.

📋 Checklist:

  • I've changed the behaviour of the code

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@gasparnagy gasparnagy merged commit ae2c9a7 into main Nov 4, 2024
4 checks passed
@gasparnagy gasparnagy deleted the systemtests_avoid_copy branch November 4, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants