Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Extensions.DependencyModel to 8.0.2 #291

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

Romfos
Copy link
Contributor

@Romfos Romfos commented Oct 14, 2024

🤔 What's changed?

  • Update Microsoft.Extensions.DependencyModel to 8.0.2

⚡️ What's your motivation?

Microsoft.Extensions.DependencyModel 8.0.1 have dependency to System.Text.Json 8.0.4
System.Text.Json 8.0.4 is marked as vulnerable by microsoft
by this reason we need to update Microsoft.Extensions.DependencyModel to 8.0.2

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

@Romfos Romfos changed the title Update Microsoft.Extensions.DependencyModel Update Microsoft.Extensions.DependencyModel to 8.0.2 Oct 14, 2024
@Romfos
Copy link
Contributor Author

Romfos commented Oct 14, 2024

Please release to nuget patched version
Maybe make sense to combine with other changes, but please don't wait too long

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the contribution.
Unfortunately in this project we need to manage the dependencies both in the project file and also in the nuspec file.

Could you please update the dependency here as well: https://github.com/reqnroll/Reqnroll/blob/main/Reqnroll/Reqnroll.nuspec

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@gasparnagy gasparnagy merged commit 188b776 into reqnroll:main Oct 16, 2024
4 checks passed
@gasparnagy
Copy link
Contributor

@Romfos Thank you for the contribution! According to our guidelines I have invited you to the Reqnroll contributors team. Congrats! 🎉 If you accept it, you will be able to make pull requests easier in the future.

You are also welcome on our discord server: https://go.reqnroll.net/discord-invite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants