Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolutionTests: Check if SDK version is installed and if not ignore the test #266

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

obligaron
Copy link
Contributor

🤔 What's changed?

Also checks for the solution tests if the required sdk is installed.

⚡️ What's your motivation?

Missed this in #109.
Found out after a fresh install of windows 11. 😉

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

I'm not sure if this change should be included in the CHANGELOG.md since it only affects Reqnroll contributors.

📋 Checklist:

  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Good to know. Thx.

@gasparnagy gasparnagy merged commit 156055b into main Oct 1, 2024
4 checks passed
@gasparnagy gasparnagy deleted the notinstalledsdk branch October 1, 2024 09:45
gasparnagy added a commit that referenced this pull request Oct 14, 2024
* main:
  Bump version
  VS Code integration  proper doc title (#280)
  Fix: Reqnroll generates invalid code for rule backgrounds in Visual Basic (#284)
  Update nunit.md (#276)
  SolutionTests: Check if SDK version is installed and if not ignore the test (#266)
  Fix for #271 This PR modifies the Feature AST visitor to appropriately handle Rule Background steps. (#272)
  Bugfix/fix reqnroll.verify parallelization (#255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants