Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing System.CodeDom in Reqnroll.CustomPlugin Nuspec file. #245

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

UL-ChrisGlew
Copy link
Contributor

🤔 What's changed?

Making Nuspec file for Reqnroll.CustomPlugin correctly reference v8.0.0 of System.CodeDom.

⚡️ What's your motivation?

Fixes #244

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@gasparnagy
Copy link
Contributor

@UL-ChrisGlew Thx. The CI produced a strange error, so I tried to re-run that. Can you check if System Tests pass for you locally?

@gasparnagy
Copy link
Contributor

The build error is independent as it also fails for the prev commit. Probably a general CI error...

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a line to the CHANGELOG.md bug fixes section related to this and also list your GitHub handle in the contirbutors list.

@gasparnagy gasparnagy merged commit fb3638f into main Sep 4, 2024
4 checks passed
@gasparnagy gasparnagy deleted the customplugin-nuspec-fix-244 branch September 4, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reqnroll.CustomPlugin has System.CodeDom version mismatch
2 participants