Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DateTimeOffsetValueComparer #180

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

cimnine
Copy link
Contributor

@cimnine cimnine commented Jun 12, 2024

🤔 What's changed?

Adds a DateTimeOffsetValueComparer, fixes #179.

⚡️ What's your motivation?

We mostly use DateTimeOffset instead of DateTime in our projects.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@gasparnagy
Copy link
Contributor

@cimnine This makes sense. Could you please check the runtime test failures?

In general it is also worth noting that we did have a retriever for DateTimeOffset, but not a comparer (I don't know why).

@cimnine cimnine force-pushed the DateTimeOffsetValueComparer branch from e3688ab to d9d6a21 Compare June 12, 2024 13:52
@cimnine
Copy link
Contributor Author

cimnine commented Jun 12, 2024

Could you please check the runtime test failures?

Done.

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the fix!

@gasparnagy gasparnagy merged commit 574d738 into reqnroll:main Jun 12, 2024
4 checks passed
@gasparnagy
Copy link
Contributor

@cimnine Thank you for the contribution! According to our guidelines I have invited you to the Reqnroll contributors team. Congrats! 🎉 If you accept it, you will be able to make pull requests easier in the future.

You are also welcome on our discord server: https://go.reqnroll.net/discord-invite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateTimeOffsetValueComparer missing
2 participants