Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-96531 || Added conditions for email optional cases #4104

Conversation

maria-hambardzumian
Copy link
Contributor

@maria-hambardzumian maria-hambardzumian commented Nov 20, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you checked that no new circular dependencies appreared with your changes? (the webpack plugin reports circular dependencies within the dev npm script)
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

Copy link
Member

@AmsterGet AmsterGet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls update tests as well.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.17%. Comparing base (2e5a087) to head (efe4c0d).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
app/src/common/utils/fieldTransformer.js 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4104      +/-   ##
===========================================
+ Coverage    61.09%   61.17%   +0.08%     
===========================================
  Files           81       81              
  Lines          897      904       +7     
  Branches       133      136       +3     
===========================================
+ Hits           548      553       +5     
- Misses         321      323       +2     
  Partials        28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@maria-hambardzumian maria-hambardzumian merged commit fea1fc1 into develop Nov 20, 2024
8 checks passed
@maria-hambardzumian maria-hambardzumian deleted the fix/EPMRPP-96531-Added-condition-for-optional-cases branch November 20, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants