Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/epmrpp 96578 merge develop to orgs #4083

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

BlazarQSO
Copy link
Contributor

@BlazarQSO BlazarQSO commented Nov 6, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you checked that no new circular dependencies appreared with your changes? (the webpack plugin reports circular dependencies within the dev npm script)
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

@BlazarQSO BlazarQSO removed the request for review from AmsterGet November 6, 2024 03:34
Copy link

sonarqubecloud bot commented Nov 6, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.12%. Comparing base (c9785c0) to head (5b8a6b6).

Additional details and impacted files
@@              Coverage Diff              @@
##           feature/orgs    #4083   +/-   ##
=============================================
  Coverage         61.12%   61.12%           
=============================================
  Files                84       84           
  Lines               926      926           
  Branches            133      133           
=============================================
  Hits                566      566           
  Misses              329      329           
  Partials             31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlazarQSO BlazarQSO merged commit b93908c into feature/orgs Nov 6, 2024
7 checks passed
@BlazarQSO BlazarQSO deleted the feature/EPMRPP-96578-merge-develop-to-orgs branch November 6, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants