Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-91529 || Launch merge. Incorrect limitation for value in the 'Description' field in the 'Merge Launches' modal #3935

Merged
merged 2 commits into from
Jul 25, 2024
Merged

EPMRPP-91529 || Launch merge. Incorrect limitation for value in the 'Description' field in the 'Merge Launches' modal #3935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5813cc1
EPMRPP-91529 || Launch merge. Incorrect limitation for value in the '…
maria-hambardzumian Jul 24, 2024
05b1705
EPMRPP-91529 || translations
maria-hambardzumian Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/localization/translated/be.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,8 +1133,8 @@
"LaunchLevelEntities.launchNumberEntityHint": "Гэты фільтр прымае толькі лічбы.",
"LaunchLevelEntities.launchNumberPlaceholder": "Увядзіце нумар",
"LaunchLevelEntities.ownerName.placeholder": "Увядзіце імя карыстальніка",
"LaunchMergeModal.launchDescriptionHint": "Description should have size not more than 1024 symbols.",
"LaunchMergeModal.launchNameHint": "Launch name should have size from 1 to 256.",
"LaunchMergeModal.launchDescriptionHint": "Апісанне павінна мець памер не больш за 2048 знакаў",
"LaunchMergeModal.launchNameHint": "Назва запуску павінна мець памер ад 1 да 256",
"LaunchStatistics.noDataMessage": "Няма запускаў",
"LaunchStatisticsControls.ContentFieldsValidationError": "Абярыце па меншай меры адзін элемент",
"LaunchStatisticsControls.CriteriaFieldLabel": "Крытэрыі для віджэта",
Expand Down
4 changes: 2 additions & 2 deletions app/localization/translated/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,7 +1133,7 @@
"LaunchLevelEntities.launchNumberEntityHint": "Este filtro solo acepta números",
"LaunchLevelEntities.launchNumberPlaceholder": "Ingrese el número",
"LaunchLevelEntities.ownerName.placeholder": "Ingrese el nombre de usuario",
"LaunchMergeModal.launchDescriptionHint": "La descripción debe tener como máximo 1024 símbolos.",
"LaunchMergeModal.launchDescriptionHint": "La descripción debe tener como máximo 2048 símbolos.",
"LaunchMergeModal.launchNameHint": "El nombre de la ejecución debe tener entre 1 y 256 caracteres.",
"LaunchStatistics.noDataMessage": "No hay ejecuciones",
"LaunchStatisticsControls.ContentFieldsValidationError": "Debe seleccionar al menos un elemento",
Expand Down Expand Up @@ -2220,4 +2220,4 @@
"usersGrid.roleNonAdmin": "No Admin",
"usersGrid.type": "Tipo",
"usersGrid.user": "Usuario"
}
}
2 changes: 1 addition & 1 deletion app/localization/translated/ru.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,7 +1133,7 @@
"LaunchLevelEntities.launchNumberEntityHint": "Этот фильтр принимает только цифры.",
"LaunchLevelEntities.launchNumberPlaceholder": "Введите номер",
"LaunchLevelEntities.ownerName.placeholder": "Введите имя пользователя",
"LaunchMergeModal.launchDescriptionHint": "Description should have size not more than 1024 symbols.",
"LaunchMergeModal.launchDescriptionHint": "Описание должно иметь размер не более 2048 символов",
"LaunchMergeModal.launchNameHint": "Имя запуска должно быть длиной от 1 до 256.",
"LaunchStatistics.noDataMessage": "Нет запусков",
"LaunchStatisticsControls.ContentFieldsValidationError": "Необходимо выбрать минимум один элемент",
Expand Down
4 changes: 2 additions & 2 deletions app/localization/translated/uk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,8 +1133,8 @@
"LaunchLevelEntities.launchNumberEntityHint": "Цей фільтр приймає тільки цифри.",
"LaunchLevelEntities.launchNumberPlaceholder": "Введіть номер",
"LaunchLevelEntities.ownerName.placeholder": "Введіть ім’я користувача",
"LaunchMergeModal.launchDescriptionHint": "Description should have size not more than 1024 symbols.",
"LaunchMergeModal.launchNameHint": "Launch name should have size from 1 to 256.",
"LaunchMergeModal.launchDescriptionHint": "Опис повинен мати розмір не більше 2048 символів",
"LaunchMergeModal.launchNameHint": "Назва запуску повинна мати розмір від 1 до 256",
"LaunchStatistics.noDataMessage": "Запусків Немає",
"LaunchStatisticsControls.ContentFieldsValidationError": "Потрібно вибрати принаймні один елемент",
"LaunchStatisticsControls.CriteriaFieldLabel": "Критерії для віджету",
Expand Down
4 changes: 2 additions & 2 deletions app/localization/translated/zh.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,7 +1133,7 @@
"LaunchLevelEntities.launchNumberEntityHint": "此过滤器仅接受数字",
"LaunchLevelEntities.launchNumberPlaceholder": "请输入编号",
"LaunchLevelEntities.ownerName.placeholder": "请输入所有者姓名",
"LaunchMergeModal.launchDescriptionHint": "描述文本的长度应不超过1024个字符",
"LaunchMergeModal.launchDescriptionHint": "描述文本的长度应不超过2048个字符",
"LaunchMergeModal.launchNameHint": "测试任务名字的取值范围是1~256。",
"LaunchStatistics.noDataMessage": "没有运行测试任务",
"LaunchStatisticsControls.ContentFieldsValidationError": "您必须至少选择一项测试项",
Expand Down Expand Up @@ -2220,4 +2220,4 @@
"usersGrid.roleNonAdmin": "非管理",
"usersGrid.type": "类型",
"usersGrid.user": "登录"
}
}
2 changes: 1 addition & 1 deletion app/src/common/utils/validation/validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const userName = composeValidators([
]);
export const filterName = composeValidators([isNotEmpty, lengthRange(3, 128)]);
export const launchName = composeValidators([isNotEmpty, maxLength(256)]);
export const launchDescription = maxLength(1024);
export const launchDescription = maxLength(2048);
export const dashboardName = composeValidators([isNotEmpty, lengthRange(3, 128)]);
export const createDashboardNameUniqueValidator = (dashboardItems, dashboardItem) => (name) =>
!dashboardItems.some((dashboard) => dashboard.name === name && dashboard.id !== dashboardItem.id);
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/fields/fieldErrorHint/fieldErrorHint.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const messages = defineMessages({
},
launchDescriptionHint: {
id: 'LaunchMergeModal.launchDescriptionHint',
defaultMessage: 'Description should have size not more than 1024 symbols.',
defaultMessage: 'Description should have size not more than 2048 symbols.',
},
dashboardNameHint: {
id: 'AddEditDashboard.dashboardNameHint',
Expand Down
2 changes: 1 addition & 1 deletion app/src/pages/inside/launchesPage/modals/launchMergeModal/launchMergeModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ export class LaunchMergeModal extends Component {
label={intl.formatMessage(messages.launchDescriptionLabel)}
labelWidth={FIELD_LABEL_WIDTH}
>
<FieldProvider name="description" maxLength={'1024'}>
<FieldProvider name="description" maxLength={'2048'}>
AmsterGet marked this conversation as resolved.
Show resolved Hide resolved
<FieldErrorHint>
<InputTextArea />
</FieldErrorHint>
Expand Down
Loading