Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-91756 || Remove old plugins mechanism #3925

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

AmsterGet
Copy link
Member

@AmsterGet AmsterGet commented Jul 19, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

@AmsterGet AmsterGet force-pushed the feature/EPMRPP-91756-remove-old-plugins-mechanism branch from 4cbcae1 to 97d3ac9 Compare July 19, 2024 15:39
@AmsterGet AmsterGet marked this pull request as ready for review July 19, 2024 15:40
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.11%. Comparing base (26b4919) to head (003fcaa).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3925   +/-   ##
========================================
  Coverage    60.11%   60.11%           
========================================
  Files           80       80           
  Lines          875      875           
  Branches       128      128           
========================================
  Hits           526      526           
  Misses         321      321           
  Partials        28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmsterGet AmsterGet force-pushed the feature/EPMRPP-91756-remove-old-plugins-mechanism branch from 97d3ac9 to 003fcaa Compare July 19, 2024 15:52
Copy link

@AmsterGet AmsterGet merged commit 86fe0db into develop Jul 22, 2024
9 checks passed
@AmsterGet AmsterGet deleted the feature/EPMRPP-91756-remove-old-plugins-mechanism branch July 22, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants