Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-91632 || Member with editor role cannot execute any actions wi… #3861

Conversation

BlazarQSO
Copy link
Contributor

@BlazarQSO BlazarQSO commented Jun 7, 2024

…th Launches in assigned project

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.51%. Comparing base (8c662fe) to head (cf04972).

Files Patch % Lines
app/src/common/utils/permissions/permissions.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feature/orgs    #3861      +/-   ##
================================================
- Coverage         61.72%   61.51%   -0.22%     
================================================
  Files                80       80              
  Lines               891      886       -5     
  Branches            129      127       -2     
================================================
- Hits                550      545       -5     
  Misses              315      315              
  Partials             26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jun 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
29.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@BlazarQSO BlazarQSO merged commit 079e448 into feature/orgs Jun 10, 2024
7 of 8 checks passed
@BlazarQSO BlazarQSO deleted the fix/EPMRPP-91632-editor-role-cannot-execute-not-own-launches branch June 10, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants