Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPMRPP-90325] || Implementation of organization Projects page #3855

Merged

Conversation

maria-hambardzumian
Copy link
Contributor

@maria-hambardzumian maria-hambardzumian commented Jun 3, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

BlazarQSO
BlazarQSO previously approved these changes Jun 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.92%. Comparing base (be2c1bd) to head (48fbddb).
Report is 15 commits behind head on feature/orgs.

Additional details and impacted files
@@              Coverage Diff              @@
##           feature/orgs    #3855   +/-   ##
=============================================
  Coverage         61.92%   61.92%           
=============================================
  Files                80       80           
  Lines               885      885           
  Branches            128      128           
=============================================
  Hits                548      548           
  Misses              311      311           
  Partials             26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AmsterGet AmsterGet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As now we have a three groups of 'internal' app pages - instance level (formerly admin), organization level, project level (formerly inside), I suppose it is the right time to adjust our folders naming. The current task is not blocked for merging by this, but let's discuss this topic at our regular meeting.

BlazarQSO
BlazarQSO previously approved these changes Jun 5, 2024
… adding 'organization' folder in 'pages' and updating file paths
… adding 'organization' folder in 'controllers' and updating file paths
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@maria-hambardzumian maria-hambardzumian merged commit 4ee540f into feature/orgs Jun 6, 2024
7 checks passed
@maria-hambardzumian maria-hambardzumian deleted the feature/EPMRPP-90325-Projects-page-layout branch June 6, 2024 08:35
import { ACTIVE_ORGANIZATION_NAMESPACE, PROJECTS_NAMESPACE } from './constants';

export const activeOrganizationReducer = (state, { type = '', payload = {} }) => {
return type === ACTIVE_ORGANIZATION_NAMESPACE ? payload : null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use action here.

if (!organization) {
throw new Error('Organization not found');
}
yield put({ type: ACTIVE_ORGANIZATION_NAMESPACE, payload: organization });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use actionCreator instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants