-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPMRPP-90325] || Implementation of organization Projects page #3855
[EPMRPP-90325] || Implementation of organization Projects page #3855
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/orgs #3855 +/- ##
=============================================
Coverage 61.92% 61.92%
=============================================
Files 80 80
Lines 885 885
Branches 128 128
=============================================
Hits 548 548
Misses 311 311
Partials 26 26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As now we have a three groups of 'internal' app pages - instance level (formerly admin), organization level, project level (formerly inside), I suppose it is the right time to adjust our folders naming. The current task is not blocked for merging by this, but let's discuss this topic at our regular meeting.
app/src/pages/inside/organizationProjectsPage/header/header.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/organizationProjectsPage/header/header.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/organizationProjectsPage/header/header.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/organizationProjectsPage/organizationProjectsPage.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/organizationProjectsPage/organizationProjectsPage.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/organizationProjectsPage/organizationProjectsPage.jsx
Outdated
Show resolved
Hide resolved
… adding 'organization' folder in 'pages' and updating file paths
… adding 'organization' folder in 'controllers' and updating file paths
Quality Gate passedIssues Measures |
import { ACTIVE_ORGANIZATION_NAMESPACE, PROJECTS_NAMESPACE } from './constants'; | ||
|
||
export const activeOrganizationReducer = (state, { type = '', payload = {} }) => { | ||
return type === ACTIVE_ORGANIZATION_NAMESPACE ? payload : null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use action here.
if (!organization) { | ||
throw new Error('Organization not found'); | ||
} | ||
yield put({ type: ACTIVE_ORGANIZATION_NAMESPACE, payload: organization }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use actionCreator instead.
PR Checklist
develop
for features/bugfixes, other if mentioned in the task)npm run lint
) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.npm run build
)?manage:translations
script?Visuals