Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/epmrpp 90913 merge develop to org #3835

Merged
merged 9 commits into from
May 17, 2024

Conversation

BlazarQSO
Copy link
Contributor

@BlazarQSO BlazarQSO commented May 17, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

maria-hambardzumian and others added 7 commits May 6, 2024 19:16
…3821)

* EPMRPP-89476 || CRUD for Slack Notification rule with dynamic fields

* EPMRPP-89476 || property fix

* EPMRPP-90767 || Update the desciption for Notification tab

* EPMRPP-89476 || Code review fix - 1

* EPMRPP-89476 || Code review fix - 2
* EPMRPP-90820 || Incorrect description for slack rules

* EPMRPP-90821 || Error on creating a duplicate of Slack/Email rule
* EPMRPP-90888 ||  Possible to create 2 Slack notification rules

* EPMRPP-90888 ||  Possible to create 2 Slack notification rules

* EPMRPP-90888 || Code Review fix - 1

* EPMRPP-90888 || Code Review fix - 2
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.08%. Comparing base (3c4ed90) to head (ac1304e).

Files Patch % Lines
app/src/common/constants/retentionPolicy.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feature/orgs    #3835      +/-   ##
================================================
- Coverage         61.15%   61.08%   -0.08%     
================================================
  Files                79       80       +1     
  Lines               865      866       +1     
  Branches            127      127              
================================================
  Hits                529      529              
- Misses              310      311       +1     
  Partials             26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AmsterGet and others added 2 commits May 17, 2024 11:07
* EPMRPP-90318 || Remote plugins support

* EPMRPP-90318 || Code review fixes - 1
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@BlazarQSO BlazarQSO merged commit 3af29ac into feature/orgs May 17, 2024
7 checks passed
@BlazarQSO BlazarQSO deleted the feature/EPMRPP-90913-merge-develop-to-org branch May 17, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants