Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-90897 || Notification rule details validation fix #3831

Merged
merged 1 commit into from
May 15, 2024

Conversation

maria-hambardzumian
Copy link
Contributor

@maria-hambardzumian maria-hambardzumian commented May 15, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.50%. Comparing base (0634b8d) to head (62a3631).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3831   +/-   ##
========================================
  Coverage    60.50%   60.50%           
========================================
  Files           80       80           
  Lines          866      866           
  Branches       127      127           
========================================
  Hits           524      524           
  Misses         315      315           
  Partials        27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maria-hambardzumian maria-hambardzumian merged commit 0dfd0c3 into develop May 15, 2024
8 checks passed
@maria-hambardzumian maria-hambardzumian deleted the EPMRPP-90897-details-validation-fix branch May 15, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants