-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPMRPP-89476 || CRUD for Slack Notification rule with dynamic fields #3821
Merged
maria-hambardzumian
merged 5 commits into
develop
from
feature/EPMRPP-89476-CRUD-Slack-Notification
May 6, 2024
Merged
EPMRPP-89476 || CRUD for Slack Notification rule with dynamic fields #3821
maria-hambardzumian
merged 5 commits into
develop
from
feature/EPMRPP-89476-CRUD-Slack-Notification
May 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maria-hambardzumian
requested review from
AmsterGet,
Vadim73i and
BlazarQSO
as code owners
May 6, 2024 07:30
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3821 +/- ##
========================================
Coverage 60.57% 60.57%
========================================
Files 79 79
Lines 865 865
Branches 127 127
========================================
Hits 524 524
Misses 314 314
Partials 27 27 ☔ View full report in Codecov by Sentry. |
AmsterGet
requested changes
May 6, 2024
...Container/content/notifications/modals/addEditNotificationModal/addEditNotificationModal.jsx
Outdated
Show resolved
Hide resolved
...ctSettingsPageContainer/content/elements/notificationRuleContent/notificationRuleContent.jsx
Outdated
Show resolved
Hide resolved
...Container/content/notifications/modals/addEditNotificationModal/addEditNotificationModal.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/projectSettingsPageContainer/content/notifications/ruleGroup/ruleGroup.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/projectSettingsPageContainer/content/notifications/notifications.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/projectSettingsPageContainer/content/notifications/ruleGroup/ruleGroup.jsx
Outdated
Show resolved
Hide resolved
...ctSettingsPageContainer/content/elements/notificationRuleContent/notificationRuleContent.jsx
Outdated
Show resolved
Hide resolved
AmsterGet
reviewed
May 6, 2024
...Container/content/notifications/modals/addEditNotificationModal/addEditNotificationModal.jsx
Show resolved
Hide resolved
app/src/pages/inside/projectSettingsPageContainer/content/notifications/ruleGroup/ruleGroup.jsx
Outdated
Show resolved
Hide resolved
maria-hambardzumian
force-pushed
the
feature/EPMRPP-89476-CRUD-Slack-Notification
branch
from
May 6, 2024 15:11
9ee2637
to
ee1349b
Compare
AmsterGet
approved these changes
May 6, 2024
Quality Gate passedIssues Measures |
maria-hambardzumian
deleted the
feature/EPMRPP-89476-CRUD-Slack-Notification
branch
May 6, 2024 15:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
develop
for features/bugfixes, other if mentioned in the task)npm run lint
) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.npm run build
)?manage:translations
script?Visuals