Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-89476 || CRUD for Slack Notification rule with dynamic fields #3821

Merged

Conversation

maria-hambardzumian
Copy link
Contributor

@maria-hambardzumian maria-hambardzumian commented May 6, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.57%. Comparing base (c7f3116) to head (7bcdc8d).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3821   +/-   ##
========================================
  Coverage    60.57%   60.57%           
========================================
  Files           79       79           
  Lines          865      865           
  Branches       127      127           
========================================
  Hits           524      524           
  Misses         314      314           
  Partials        27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maria-hambardzumian maria-hambardzumian force-pushed the feature/EPMRPP-89476-CRUD-Slack-Notification branch from 9ee2637 to ee1349b Compare May 6, 2024 15:11
Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@maria-hambardzumian maria-hambardzumian merged commit dccd910 into develop May 6, 2024
8 checks passed
@maria-hambardzumian maria-hambardzumian deleted the feature/EPMRPP-89476-CRUD-Slack-Notification branch May 6, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants