Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-89659 || Update notification tab layout (#3795) #3804

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

maria-hambardzumian
Copy link
Contributor

@maria-hambardzumian maria-hambardzumian commented Apr 19, 2024

  • EPMRPP-89790 | updated notification modal (field for webhook url)

  • EPMRPP-89790 | updated modal's field message

  • EPMRPP-89790 | Implemented help panel section

  • EPMRPP-89790 | Notification footer with appropriate data items

  • EPMRPP-89790 | Notification footer style

  • EPMRPP-89790 | Include WebhookURL in constants

  • EPMRPP-89687 | Map enabled notification plugin group

  • EPMRPP-89687 | Include empty state for each plugin

  • EPMRPP-89687 | Update notification messages

    • changes from translations
    • added 2 icons for helpPanel
  • EPMRPP-89687 | fixes to open modal

    • fix SonarLint
    • replaced attribute selector
  • EPRRPP-89659 | Fixes

  • EPRRPP-89659 | type prop validation

    • fixes & additions
  • EPMRPP-89781 | Implement own toggler for each group

  • EPMRPP-89781 | fixes

  • EPMRPP-89781 | Sonar fix

  • EPMRPP-89781 | remove lock action


PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

* EPMRPP-89790 | updated notification modal (field for webhook url)

* EPMRPP-89790 | updated modal's field message

* EPMRPP-89790 | Implemented help panel section

* EPMRPP-89790 | Notification footer with appropriate data items

* EPMRPP-89790 | Notification footer style

* EPMRPP-89790 | Include WebhookURL in constants

* EPMRPP-89687 | Map enabled notification plugin group

* EPMRPP-89687 | Include empty state for each plugin

* EPMRPP-89687 | Update notification messages

* - changes from translations

* - added 2 icons for helpPanel

* EPMRPP-89687 | fixes to open modal

* - fix SonarLint

* - replaced attribute selector

* EPRRPP-89659 | Fixes

* EPRRPP-89659 | type prop validation

* - fixes & additions

* EPMRPP-89781 | Implement own toggler for each group

* EPMRPP-89781 | fixes

* EPMRPP-89781 | Sonar fix

* EPMRPP-89781 | remove lock action

---------

Co-authored-by: MariaHambardzumian <[email protected]>
@AmsterGet AmsterGet force-pushed the feature/notifications branch from 201168f to b8852d2 Compare April 19, 2024 13:38
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@maria-hambardzumian maria-hambardzumian merged commit d5b8b19 into develop Apr 19, 2024
7 checks passed
@maria-hambardzumian maria-hambardzumian deleted the feature/notifications branch April 19, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants