Skip to content

Commit

Permalink
fix: fix eight circular deps
Browse files Browse the repository at this point in the history
  • Loading branch information
iso9000t committed Jan 5, 2025
1 parent 714e367 commit f3a57e0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions app/src/common/utils/validation/commonValidators.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
* limitations under the License.
*/

import { commonValidators } from 'common/utils/validation/index';
import * as validate from './validate';
import { bindMessageToValidator, composeBoundValidators } from './validatorHelpers';

Expand Down Expand Up @@ -75,7 +74,7 @@ export const createRuleNameValidator = (notifications, notificationId) =>
]);
export const createProjectNameValidator = () =>
composeBoundValidators([
commonValidators.requiredField,
requiredField,
bindMessageToValidator(validate.projectNameLength, 'projectNameLengthHint'),
bindMessageToValidator(validate.projectNamePattern, 'projectNamePatternHint'),
]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import { normalizeEventString } from 'components/main/analytics';
import { normalizeEventString } from '../utils';
import { getBasicClickEventParameters, getBasicSearchEventParameters } from './common/ga4Utils';

const SIDEBAR = 'sidebar';
Expand Down
4 changes: 2 additions & 2 deletions app/src/controllers/filter/sagas.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ import {
import { showNotification, NOTIFICATION_TYPES } from 'controllers/notification';
import { userIdSelector } from 'controllers/user';
import { URLS } from 'common/urls';
import { userFiltersSelector } from 'controllers/project/selectors';
import { userFiltersSelector, projectKeySelector } from 'controllers/project/selectors';
import {
updateProjectFilterPreferencesAction,
fetchProjectPreferencesAction,
} from 'controllers/project/actionCreators';
import { projectKeySelector } from 'controllers/project';

import {
urlOrganizationAndProjectSelector,
PROJECT_LAUNCHES_PAGE,
Expand Down

0 comments on commit f3a57e0

Please sign in to comment.