Skip to content

Commit

Permalink
EPMRPP-93055 || code review fix - 1
Browse files Browse the repository at this point in the history
  • Loading branch information
maria-hambardzumian committed Jul 19, 2024
1 parent 52dbba2 commit da9ccfd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 15 deletions.
10 changes: 2 additions & 8 deletions app/src/controllers/uniqueErrors/sagas.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,7 @@
import { all, call, put, select, take, takeEvery } from 'redux-saga/effects';
import { URLS } from 'common/urls';
import { activeProjectSelector } from 'controllers/user';
import {
fetchParentItems,
fetchParentLaunch,
launchSelector,
namespaceSelector,
} from 'controllers/testItem';
import { fetchParentItems, fetchParentLaunch, launchSelector } from 'controllers/testItem';
import { createFetchPredicate, fetchDataAction } from 'controllers/fetch';
import {
launchIdSelector,
Expand Down Expand Up @@ -83,8 +78,7 @@ function* fetchClusters(payload = {}) {
yield call(fetchParentLaunch, { payload: { project, launchId } });
}

const namespace = yield select(namespaceSelector);
const query = yield select(queryParametersSelector, namespace);
const query = yield select(queryParametersSelector, NAMESPACE);
let url;
const requestParams = {};
const plugin = yield call(getPlugin);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,5 @@ UniqueErrorsGridWrapped.defaultProps = {
export const UniqueErrorsGrid = withSortingURL({
defaultFields: [MATCHED_TESTS_COLUMN_ID],
defaultDirection: SORTING_DESC,
namespace: NAMESPACE,
})(UniqueErrorsGridWrapped);
10 changes: 3 additions & 7 deletions app/src/pages/inside/uniqueErrorsPage/uniqueErrorsPage.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,14 @@ import React, { Component } from 'react';
import { PageLayout, PageSection } from 'layouts/pageLayout';
import { connect } from 'react-redux';
import track from 'react-tracking';
import {
deleteTestItemsAction,
launchSelector,
namespaceSelector,
parentItemSelector,
} from 'controllers/testItem';
import { deleteTestItemsAction, launchSelector, parentItemSelector } from 'controllers/testItem';
import {
clustersSelector,
fetchClustersAction,
loadingSelector,
pageLoadingSelector,
uniqueErrorsPaginationSelector,
NAMESPACE,
} from 'controllers/uniqueErrors';
import PropTypes from 'prop-types';
import { SpinningPreloader } from 'components/preloaders/spinningPreloader';
Expand Down Expand Up @@ -108,7 +104,7 @@ const UNLINK_ISSUE_EVENTS_INFO = {
)
@withPagination({
paginationSelector: uniqueErrorsPaginationSelector,
namespaceSelector,
namespace: NAMESPACE,
})
@injectIntl
@track({ page: UNIQUE_ERRORS_PAGE })
Expand Down

0 comments on commit da9ccfd

Please sign in to comment.