EPMRPP-88921 || Extra event is sent to GA when clicking on Submit but…

…ton (#3720) * EPMRPP-88921 || Extra event is sent to GA when clicking on Submit button * EPMRPP-88921 || Code Review fix - 1
reportportal · Jan 12, 2024 · a4f4584 · a4f4584
1 parent e4a9079
commit a4f4584
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 17 deletions.
diff --git a/app/src/components/main/analytics/events/ga4Events/projectSettingsPageEvents.js b/app/src/components/main/analytics/events/ga4Events/projectSettingsPageEvents.js
@@ -61,21 +61,15 @@ const getStatus = (status) => (status ? 'active' : 'disabled');
 const getSwitcher = (switcher) => (switcher ? 'on' : 'off');
 
 export const PROJECT_SETTINGS_ANALYZER_EVENTS = {
-  clickSubmitInIndexTab: (number, status) => ({
-    ...BASIC_EVENT_PARAMETERS_ANALYZER_TAB,
-    element_name: 'button_submit',
-    place: `${ANALYZER}_index_settings`,
-    number,
-    status: getStatus(status),
-  }),
-
-  clickSubmitInAutoAnalyzerTab: (number, status, condition) => ({
+  clickSubmitInAutoAnalyzerTab: (number, status, condition, switcher, type) => ({
     ...BASIC_EVENT_PARAMETERS_ANALYZER_TAB,
     place: `${ANALYZER}_auto_analyzer`,
     element_name: 'button_submit',
     number,
     status: getStatus(status),
     condition: LAUNCH_ANALYZE_TYPES_TO_ANALYTICS_TITLES_MAP[condition],
+    switcher,
+    type,
   }),
 
   clickSubmitInSimilarItemsTab: (number) => ({

diff --git a/...side/projectSettingsPageContainer/content/analyzerContainer/autoAnalysis/autoAnalysis.jsx b/...side/projectSettingsPageContainer/content/analyzerContainer/autoAnalysis/autoAnalysis.jsx
@@ -100,20 +100,15 @@ const AutoAnalysis = ({
     await onFormSubmit(data);
     setPending(false);
 
+    const numberOfLogLines = data[NUMBER_OF_LOG_LINES] === '-1' ? 'all' : data[NUMBER_OF_LOG_LINES];
+
     trackEvent(
       PROJECT_SETTINGS_ANALYZER_EVENTS.clickSubmitInAutoAnalyzerTab(
         data[MIN_SHOULD_MATCH],
         data[ANALYZER_ENABLED],
         data[ANALYZER_MODE],
-      ),
-    );
-
-    const numberOfLogLines = data[NUMBER_OF_LOG_LINES] === '-1' ? 'all' : data[NUMBER_OF_LOG_LINES];
-
-    trackEvent(
-      PROJECT_SETTINGS_ANALYZER_EVENTS.clickSubmitInIndexTab(
-        numberOfLogLines,
         data[ALL_MESSAGES_SHOULD_MATCH],
+        numberOfLogLines,
       ),
     );
   };