-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.13.5 #2185
base: master
Are you sure you want to change the base?
Release 5.13.5 #2185
Conversation
EPMRPP-98912 || Add test case search widget type
EPMRPP-98912 || Add test case search widget type
…t after reloading the page (cherry picked from commit ade0d3e)
@Schema(required = true, allowableValues = | ||
"oldLineChart, investigatedTrend, launchStatistics, statisticTrend," | ||
+ " casesTrend, notPassed, overallStatistics, uniqueBugTable, bugTrend, activityStream, launchesComparisonChart," | ||
+ " launchesDurationChart, launchesTable, topTestCases, flakyTestCases, passingRateSummary, passingRatePerLaunch," | ||
+ " productStatus, mostTimeConsuming, cumulative, topPatternTemplates, componentHealthCheck, componentHealthCheckTable") | ||
+ " productStatus, mostTimeConsuming, cumulative, topPatternTemplates, componentHealthCheck, componentHealthCheckTable," |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 130).
|
||
} | ||
@NotBlank | ||
@Size(min = ValidationConstraints.MIN_PASSWORD_LENGTH, max = ValidationConstraints.MAX_PASSWORD_LENGTH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 105).
@JsonInclude(JsonInclude.Include.NON_NULL) | ||
public class ChangePasswordRQ { | ||
|
||
@NotBlank | ||
@Size(min = ValidationConstraints.MIN_PASSWORD_LENGTH, max = ValidationConstraints.MAX_PASSWORD_LENGTH) | ||
@Pattern(regexp = USER_PASSWORD_REGEXP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annotation 'Pattern' have incorrect indentation level 2, expected level should be 1.
|
||
} | ||
@NotBlank | ||
@Size(min = ValidationConstraints.MIN_PASSWORD_LENGTH, max = ValidationConstraints.MAX_PASSWORD_LENGTH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 105).
@JsonInclude(JsonInclude.Include.NON_NULL) | ||
public class ChangePasswordRQ { | ||
|
||
@NotBlank | ||
@Size(min = ValidationConstraints.MIN_PASSWORD_LENGTH, max = ValidationConstraints.MAX_PASSWORD_LENGTH) | ||
@Pattern(regexp = USER_PASSWORD_REGEXP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annotation 'Pattern' have incorrect indentation level 2, expected level should be 1.
… into EPMRPP-98912 � Conflicts: � build.gradle
EPMRPP-98912 || Add test case search endpoint
@@ -38,11 +38,10 @@ | |||
public class ContentParameters { | |||
|
|||
// fields for main data(for example: graphs at the chart) | |||
@JsonProperty(value = "contentFields", required = true) | |||
@JsonProperty(value = "contentFields") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
@@ -38,11 +38,10 @@ | |||
public class ContentParameters { | |||
|
|||
// fields for main data(for example: graphs at the chart) | |||
@JsonProperty(value = "contentFields", required = true) | |||
@JsonProperty(value = "contentFields") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'member def modifier' has incorrect indentation level 8, expected level should be 2.
private List<String> contentFields; | ||
|
||
@NotNull | ||
@JsonProperty(value = "itemsCount", required = true) | ||
@JsonProperty(value = "itemsCount") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
private List<String> contentFields; | ||
|
||
@NotNull | ||
@JsonProperty(value = "itemsCount", required = true) | ||
@JsonProperty(value = "itemsCount") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'member def modifier' has incorrect indentation level 8, expected level should be 2.
private final Collection<T> content; | ||
private final PageMetadata page; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First sentence of Javadoc is missing an ending period.
this.hasNext = hasNext; | ||
} | ||
|
||
public PageMetadata(long size, long number, long totalElements, long totalPages) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a Javadoc comment.
@@ -245,7 +243,7 @@ public OperationCompletionRS handleSuggestChoose(@PathVariable String projectNam | |||
@Schema(implementation = TestItemHistoryElement.class) | |||
public Iterable<TestItemResource> getTestItems(@PathVariable String projectName, | |||
@AuthenticationPrincipal ReportPortalUser user, @Nullable | |||
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ | |||
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + EQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'@' has incorrect indentation level 2, expected level should be 6.
@@ -336,13 +334,13 @@ | |||
@AuthenticationPrincipal ReportPortalUser user, @FilterFor(TestItem.class) Filter filter, | |||
@FilterFor(TestItem.class) Queryable predefinedFilter, | |||
@SortFor(TestItem.class) Pageable pageable, @Nullable | |||
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ | |||
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + EQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'@' has incorrect indentation level 2, expected level should be 6.
+ CRITERIA_PARENT_ID, required = false) | ||
Long parentId, @Nullable | ||
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ | ||
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + EQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'@' has incorrect indentation level 2, expected level should be 6.
+ CRITERIA_ID, required = false) | ||
Long itemId, @Nullable | ||
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ | ||
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + EQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'@' has incorrect indentation level 2, expected level should be 6.
import org.springframework.stereotype.Service; | ||
|
||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary javadoc is missing.
PageMetadata() { | ||
} | ||
|
||
public PageMetadata(Integer number, Integer size, Boolean hasNext) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a Javadoc comment.
resourceUpdaters.forEach(updater -> updater.updateResource(testItemResource)); | ||
return testItemResource; | ||
}).collect(toList()), | ||
new PageMetadata(result.getPageable().getPageNumber() + 1, result.getPageable().getPageSize(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 102).
No description provided.