Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.13.5 #2185

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Release 5.13.5 #2185

wants to merge 36 commits into from

Conversation

APiankouski
Copy link
Contributor

No description provided.

@Schema(required = true, allowableValues =
"oldLineChart, investigatedTrend, launchStatistics, statisticTrend,"
+ " casesTrend, notPassed, overallStatistics, uniqueBugTable, bugTrend, activityStream, launchesComparisonChart,"
+ " launchesDurationChart, launchesTable, topTestCases, flakyTestCases, passingRateSummary, passingRatePerLaunch,"
+ " productStatus, mostTimeConsuming, cumulative, topPatternTemplates, componentHealthCheck, componentHealthCheckTable")
+ " productStatus, mostTimeConsuming, cumulative, topPatternTemplates, componentHealthCheck, componentHealthCheckTable,"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 130).


}
@NotBlank
@Size(min = ValidationConstraints.MIN_PASSWORD_LENGTH, max = ValidationConstraints.MAX_PASSWORD_LENGTH)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 105).

@JsonInclude(JsonInclude.Include.NON_NULL)
public class ChangePasswordRQ {

@NotBlank
@Size(min = ValidationConstraints.MIN_PASSWORD_LENGTH, max = ValidationConstraints.MAX_PASSWORD_LENGTH)
@Pattern(regexp = USER_PASSWORD_REGEXP)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] reported by reviewdog 🐶
Annotation 'Pattern' have incorrect indentation level 2, expected level should be 1.


}
@NotBlank
@Size(min = ValidationConstraints.MIN_PASSWORD_LENGTH, max = ValidationConstraints.MAX_PASSWORD_LENGTH)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 105).

@JsonInclude(JsonInclude.Include.NON_NULL)
public class ChangePasswordRQ {

@NotBlank
@Size(min = ValidationConstraints.MIN_PASSWORD_LENGTH, max = ValidationConstraints.MAX_PASSWORD_LENGTH)
@Pattern(regexp = USER_PASSWORD_REGEXP)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] reported by reviewdog 🐶
Annotation 'Pattern' have incorrect indentation level 2, expected level should be 1.

@pbortnik pbortnik changed the title Rc/5.13.5 Release 5.13.5 Feb 28, 2025
@@ -38,11 +38,10 @@
public class ContentParameters {

// fields for main data(for example: graphs at the chart)
@JsonProperty(value = "contentFields", required = true)
@JsonProperty(value = "contentFields")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@@ -38,11 +38,10 @@
public class ContentParameters {

// fields for main data(for example: graphs at the chart)
@JsonProperty(value = "contentFields", required = true)
@JsonProperty(value = "contentFields")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 8, expected level should be 2.

private List<String> contentFields;

@NotNull
@JsonProperty(value = "itemsCount", required = true)
@JsonProperty(value = "itemsCount")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

private List<String> contentFields;

@NotNull
@JsonProperty(value = "itemsCount", required = true)
@JsonProperty(value = "itemsCount")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 8, expected level should be 2.

private final Collection<T> content;
private final PageMetadata page;

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
First sentence of Javadoc is missing an ending period.

this.hasNext = hasNext;
}

public PageMetadata(long size, long number, long totalElements, long totalPages) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> reported by reviewdog 🐶
Missing a Javadoc comment.

@@ -245,7 +243,7 @@ public OperationCompletionRS handleSuggestChoose(@PathVariable String projectNam
@Schema(implementation = TestItemHistoryElement.class)
public Iterable<TestItemResource> getTestItems(@PathVariable String projectName,
@AuthenticationPrincipal ReportPortalUser user, @Nullable
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + EQ

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'@' has incorrect indentation level 2, expected level should be 6.

@@ -336,13 +334,13 @@
@AuthenticationPrincipal ReportPortalUser user, @FilterFor(TestItem.class) Filter filter,
@FilterFor(TestItem.class) Queryable predefinedFilter,
@SortFor(TestItem.class) Pageable pageable, @Nullable
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + EQ

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'@' has incorrect indentation level 2, expected level should be 6.

+ CRITERIA_PARENT_ID, required = false)
Long parentId, @Nullable
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + EQ

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'@' has incorrect indentation level 2, expected level should be 6.

+ CRITERIA_ID, required = false)
Long itemId, @Nullable
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ
@Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + EQ

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'@' has incorrect indentation level 2, expected level should be 6.

import org.springframework.stereotype.Service;


/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.

PageMetadata() {
}

public PageMetadata(Integer number, Integer size, Boolean hasNext) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> reported by reviewdog 🐶
Missing a Javadoc comment.

resourceUpdaters.forEach(updater -> updater.updateResource(testItemResource));
return testItemResource;
}).collect(toList()),
new PageMetadata(result.getPageable().getPageNumber() + 1, result.getPageable().getPageSize(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 102).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants