Merge branch 'master' into rc/5.11.0

build.gradle

@@ -96,6 +96,9 @@ dependencies {
     testCompileOnly "org.projectlombok:lombok:${lombokVersion}"
     testAnnotationProcessor "org.projectlombok:lombok:${lombokVersion}"
 
+    implementation 'org.springframework.boot:spring-boot-starter-cache'
+    implementation 'com.github.ben-manes.caffeine:caffeine'
+
     testCompile 'org.springframework.boot:spring-boot-starter-test'
     testCompile 'org.flywaydb.flyway-test-extensions:flyway-spring-test:6.1.0'
 

gradle.properties

@@ -1,2 +1,2 @@
 version=5.11.0
-lombokVersion=1.18.30
+lombokVersion=1.18.30

src/main/java/com/epam/ta/reportportal/config/ApiKeyCacheResolver.java

@@ -1,9 +1,25 @@
+/*
+ * Copyright 2023 EPAM Systems
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package com.epam.ta.reportportal.config;
 
 import com.epam.ta.reportportal.dao.ApiKeyRepository;
 import com.epam.ta.reportportal.entity.user.ApiKey;
 import java.util.ArrayList;
 import java.util.Collection;
+import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.cache.Cache;
 import org.springframework.cache.CacheManager;
 import org.springframework.cache.interceptor.CacheOperationInvocationContext;
@@ -23,17 +39,16 @@ public class ApiKeyCacheResolver implements CacheResolver {
 
   private final CacheManager cacheManager;
 
-  public ApiKeyCacheResolver(ApiKeyRepository apiKeyRepository, CacheManager cacheManager) {
+  public ApiKeyCacheResolver(ApiKeyRepository apiKeyRepository,
+      @Qualifier("caffeineCacheManager") CacheManager cacheManager) {
     this.apiKeyRepository = apiKeyRepository;
     this.cacheManager = cacheManager;
   }
 
   @Override
   @NonNull
   public Collection<? extends Cache> resolveCaches(CacheOperationInvocationContext<?> context) {
-    Long apiKeyId = (Long) context.getArgs()[0];
-    ApiKey apiKey = apiKeyRepository.findById(apiKeyId).orElse(null);
-
+    Cache cache = cacheManager.getCache("apiKeyCache");
     Collection<Cache> caches = new ArrayList<>();
     if (apiKey != null && context.getOperation().getCacheNames().contains("apiKeyCache")) {
       Cache cache = cacheManager.getCache("apiKeyCache");
@@ -42,6 +57,7 @@ public Collection<? extends Cache> resolveCaches(CacheOperationInvocationContext
         caches.add(cache);
       }
     }
+
     return caches;
   }
 }

src/main/java/com/epam/ta/reportportal/config/CacheConfiguration.java

@@ -0,0 +1,44 @@
+/*
+ * Copyright 2023 EPAM Systems
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.epam.ta.reportportal.config;
+
+import com.github.benmanes.caffeine.cache.Caffeine;
+import java.util.concurrent.TimeUnit;
+import org.springframework.cache.CacheManager;
+import org.springframework.cache.caffeine.CaffeineCacheManager;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+
+/**
+ * Configuration for cache manager.
+ *
+ * @author Ivan Kustau
+ */
+@Configuration
+public class CacheConfiguration {
+
+  @Bean("caffeineCacheManager")
+  public CacheManager cacheManager() {
+    CaffeineCacheManager cacheManager = new CaffeineCacheManager();
+    cacheManager.setCaffeine(cacheProperties());
+    return cacheManager;
+  }
+
+  private Caffeine<Object, Object> cacheProperties() {
+    return Caffeine.newBuilder().expireAfterWrite(30, TimeUnit.SECONDS);
+  }
+}

src/main/java/com/epam/ta/reportportal/dao/ActivityRepository.java

@@ -17,8 +17,6 @@
 package com.epam.ta.reportportal.dao;
 
 import com.epam.ta.reportportal.entity.activity.Activity;
-import java.util.List;
-import org.springframework.data.jpa.repository.Query;
 
 /**
  * Repository for {@link Activity} entity
@@ -28,7 +26,4 @@
 public interface ActivityRepository extends ReportPortalRepository<Activity, Long>,
     ActivityRepositoryCustom {
 
-  @Query(value = "SELECT DISTINCT a.subject_name FROM Activity a WHERE a.project_id = :projectId AND LOWER(a.subject_name) LIKE %:value%", nativeQuery = true)
-  List<String> findSubjectNameByProjectIdAndSubjectName(Long projectId, String value);
-
 }

src/main/java/com/epam/ta/reportportal/dao/ApiKeyRepository.java

@@ -36,7 +36,7 @@ public interface ApiKeyRepository
    * @param hash hash of api key
    * @return {@link ApiKey}
    */
-  @Cacheable(value = "apiKeyCache", key = "#hash")
+  @Cacheable(value = "apiKeyCache", key = "#hash", cacheResolver = "apiKeyCacheResolver")
   ApiKey findByHash(String hash);
 
   /**

src/test/java/com/epam/ta/reportportal/config/TestConfiguration.java

@@ -22,11 +22,15 @@
 import com.epam.reportportal.commons.TikaContentTypeResolver;
 import com.epam.ta.reportportal.filesystem.DataEncoder;
 import com.epam.ta.reportportal.util.FeatureFlagHandler;
+import com.github.benmanes.caffeine.cache.Caffeine;
 import java.util.Set;
+import java.util.concurrent.TimeUnit;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
 import org.springframework.boot.autoconfigure.quartz.QuartzAutoConfiguration;
 import org.springframework.boot.context.properties.EnableConfigurationProperties;
+import org.springframework.cache.CacheManager;
+import org.springframework.cache.caffeine.CaffeineCacheManager;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.Configuration;
@@ -69,4 +73,15 @@ public DataEncoder dataEncoder() {
     return new DataEncoder();
   }
 
+  @Bean(name = "caffeineCacheManager")
+  public CacheManager cacheManager() {
+    CaffeineCacheManager cacheManager = new CaffeineCacheManager();
+    cacheManager.setCaffeine(cacheProperties());
+    return cacheManager;
+  }
+
+  private Caffeine<Object, Object> cacheProperties() {
+    return Caffeine.newBuilder().expireAfterWrite(1, TimeUnit.MINUTES);
+  }
+
 }

src/test/java/com/epam/ta/reportportal/filesystem/distributed/s3/S3DataStoreTest.java

@@ -75,7 +75,7 @@ void save() throws Exception {
     s3DataStore.save(FILE_PATH, inputStream);
 
     verify(blobStore, times(1))
-        .putBlob(BUCKET_PREFIX + DEFAULT_BUCKET_NAME + BUCKET_POSTFIX, blobMock);
+        .putBlob(DEFAULT_BUCKET_NAME, blobMock);
   }
 
   @Test
@@ -87,7 +87,7 @@ void load() throws Exception {
     when(mockPayload.openStream()).thenReturn(inputStream);
     when(mockBlob.getPayload()).thenReturn(mockPayload);
 
-    when(blobStore.getBlob(BUCKET_PREFIX + DEFAULT_BUCKET_NAME + BUCKET_POSTFIX,
+    when(blobStore.getBlob(DEFAULT_BUCKET_NAME,
         FILE_PATH)).thenReturn(mockBlob);
     InputStream loaded = s3DataStore.load(FILE_PATH);
 
@@ -100,6 +100,6 @@ void delete() throws Exception {
     s3DataStore.delete(FILE_PATH);
 
     verify(blobStore, times(1))
-        .removeBlob(BUCKET_PREFIX + DEFAULT_BUCKET_NAME + BUCKET_POSTFIX, FILE_PATH);
+        .removeBlob(DEFAULT_BUCKET_NAME, FILE_PATH);
   }
 }