Update attachments.js : Add timeout before resolve files #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cypress video processing may take extra time after the spec is complete, so add a timeout to wait for the video file readiness.
The moov atom in an MP4 file is a crucial part of the file’s structure. It contains metadata about the video, such as the duration, display characteristics, and timing information. Function check for the moov atom in file content and ensure is video file rediness
AmsterGet
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Hello @ashvinjaiswal !
Thank you for the suggested fix, your input is very much appreciated :)
Before release, I will merge your check with the waitForFile function to use a single timeout for them, if you don't mind.
Please fix the linter errors to unlock the merge.
|
Hello @AmsterGet, Thanks for review. Let me fix the lint issue. |
|
Hi @AmsterGet, I have fixed lint issue. Thanks |
AmsterGet
approved these changes
Aug 28, 2024
|
Thank you @ashvinjaiswal ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes resolves #202 by adding timeout from option for video file readiness.
Cypress video processing may take extra time after the spec is complete, so add a timeout to wait for the video file readiness.