Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add google auth login #662

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add google auth login #662

wants to merge 2 commits into from

Conversation

MickaelCa
Copy link

@MickaelCa MickaelCa commented Sep 8, 2023 •
edited
Loading

we use Google SSO so I added it

@MickaelCa MickaelCa marked this pull request as ready for review September 8, 2023 17:29
@MickaelCa
Copy link
Author

MickaelCa commented Jan 10, 2024 •
edited
Loading

PR rebased for conflicts

@MickaelCa
Copy link
Author

any chance to see this merged ?

@TheoAlloin
Copy link

@sztwiorok any chance to review this PR?

@sztwiorok
Copy link
Contributor

@MickaelCa @TheoAlloin We will review and merge it in a week

@sztwiorok
Copy link
Contributor

we checked the code and everything is fine. @MickaelCa could you make some small change in the code to run the GHA tests again?

@MickaelCa
Copy link
Author

@sztwiorok I rebased on main and force-pushed, should be enough!

@sztwiorok
Copy link
Contributor

@MickaelCa thanks
code style tests failed, could you look at this?

@sztwiorok
Copy link
Contributor

@MickaelCa, there are problems with unit tests, could you look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MickaelCa @TheoAlloin @sztwiorok