Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the tryPort to use hostname.local (for wsl to work) #582

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thatgurkangurk
Copy link
Contributor

when you try to use the --watch flag in wsl, it cannot connect since the networks are technically separated. if you use hostname.local however, the wsl "container" can connect to the main windows machine.

this should not break any other systems since i tested it in linux, linux in wsl and on windows without issue

pnpm-lock.yaml Outdated Show resolved Hide resolved
Copy link
Member

@12944qwerty 12944qwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unfortunately isn't supported on Mac devices. You may need to add a check to see if it's mac or not to choose to use .local or localhost.

@FedeIlLeone FedeIlLeone added bug Something isn't working semver: patch Requires a patch semver version bump addon development Relates to developing addons, eg APIs or scripts labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon development Relates to developing addons, eg APIs or scripts bug Something isn't working semver: patch Requires a patch semver version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants