Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.4 createRequire to allow copy loader from esbuild to work in SEA #48

Merged
merged 7 commits into from
Oct 8, 2024
+8 −6
Merged

3.2.4 createRequire to allow copy loader from esbuild to work in SEA #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f173e52
dont try to resize if we invalidated the fd
jackyzha0 Sep 20, 2024
1e74541
Merge branch 'main' of https://github.com/replit/ruspty
jackyzha0 Oct 4, 2024
0c9cf77
Merge branch 'main' of https://github.com/replit/ruspty
jackyzha0 Oct 4, 2024
1e9bf80
Merge branch 'main' of https://github.com/replit/ruspty
jackyzha0 Oct 8, 2024
87d2a20
fix require clause
jackyzha0 Oct 8, 2024
7fed2a6
3.2.4
jackyzha0 Oct 8, 2024
ca69a20
remove semis for consistency
jackyzha0 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

const { existsSync, readFileSync } = require('fs')
const { join } = require('path')
const { createRequire } = require('node:module')
require = createRequire(__filename)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not const require make it local?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 the node docs recommend it like this, i assume theres some static analysis things at work here


const { platform, arch } = process

Expand Down
2 changes: 1 addition & 1 deletion npm/darwin-arm64/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@replit/ruspty-darwin-arm64",
"version": "3.2.3",
"version": "3.2.4",
"os": [
"darwin"
],
Expand Down
2 changes: 1 addition & 1 deletion npm/darwin-x64/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@replit/ruspty-darwin-x64",
"version": "3.2.3",
"version": "3.2.4",
"os": [
"darwin"
],
Expand Down
2 changes: 1 addition & 1 deletion npm/linux-x64-gnu/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@replit/ruspty-linux-x64-gnu",
"version": "3.2.3",
"version": "3.2.4",
"os": [
"linux"
],
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@replit/ruspty",
"version": "3.2.3",
"version": "3.2.4",
"main": "dist/wrapper.js",
"types": "dist/wrapper.d.ts",
"author": "Szymon Kaliski <[email protected]>",
Expand Down