Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch everything to node and dont use O_NONBLOCK #25

Merged
merged 44 commits into from
Jun 8, 2024
+4,226 −1,017
Merged

switch everything to node and dont use O_NONBLOCK #25

Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
7f35457
switch everything to node
jackyzha0 Jun 5, 2024
cb1ef5f
oops forgot packagelock
jackyzha0 Jun 5, 2024
0904a82
3.0.0
jackyzha0 Jun 5, 2024
605b315
test fixes
jackyzha0 Jun 5, 2024
e5413e7
only
jackyzha0 Jun 5, 2024
fb3e5da
use nix instead of rustix, convert to blocking mode
jackyzha0 Jun 6, 2024
cf94ce8
try to fix ci?
jackyzha0 Jun 6, 2024
1e5762c
strip w -x
jackyzha0 Jun 6, 2024
0f9c8c6
language agnostic build
jackyzha0 Jun 6, 2024
d49fdb0
change recommended start strat
jackyzha0 Jun 6, 2024
998c8c3
update package json, try not stripping
jackyzha0 Jun 6, 2024
b4286f2
remove concurrent sad
jackyzha0 Jun 6, 2024
28270d1
bad assert
jackyzha0 Jun 6, 2024
fa4d05d
try specifying target again
jackyzha0 Jun 6, 2024
3391137
dont ci
jackyzha0 Jun 6, 2024
c47260a
fix linux tests
jackyzha0 Jun 6, 2024
ced5a0e
try not using docker??
jackyzha0 Jun 6, 2024
a3df0bb
combine build and test
jackyzha0 Jun 6, 2024
9cd45d2
simplify even more
jackyzha0 Jun 6, 2024
7adb3cd
fix upload path
jackyzha0 Jun 6, 2024
9243065
try not repeating?
jackyzha0 Jun 6, 2024
859f26c
dont repeat, abstract rejectOnNonEIO
jackyzha0 Jun 6, 2024
add0b3c
?????
jackyzha0 Jun 6, 2024
8edfc51
only run publish on main
jackyzha0 Jun 6, 2024
728fb16
try 50 again?
jackyzha0 Jun 6, 2024
82d0861
lower repeat?? idk
jackyzha0 Jun 6, 2024
26e702e
add before/aftereach
jackyzha0 Jun 6, 2024
6720477
try without cloning
jackyzha0 Jun 6, 2024
e91e2c8
cleanup/teardown improvement
jackyzha0 Jun 6, 2024
ff9016b
now try bumping retry
jackyzha0 Jun 6, 2024
6c16e58
50???? john pls
jackyzha0 Jun 6, 2024
42f3552
drop controller fd
jackyzha0 Jun 6, 2024
23b6009
use unsafe close
jackyzha0 Jun 6, 2024
627c699
wait for the right things...
jackyzha0 Jun 6, 2024
38e7a0b
bump retries
jackyzha0 Jun 6, 2024
b1d19d2
add poll
jackyzha0 Jun 7, 2024
f2255b0
use end instead of close
jackyzha0 Jun 7, 2024
546eae7
wrapper time
jackyzha0 Jun 7, 2024
3d82fdf
update docs, remove extra ports from .replit
jackyzha0 Jun 7, 2024
2365f06
run 1000??
jackyzha0 Jun 7, 2024
25b6d59
stty is bad
jackyzha0 Jun 7, 2024
4f0fd09
add ordering test
jackyzha0 Jun 7, 2024
9895696
some test cleanup
jackyzha0 Jun 8, 2024
99fdc02
remove only modifier
jackyzha0 Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
50???? john pls
@jackyzha0
jackyzha0 committed Jun 6, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 6c16e58a32344d02d3b4af7a83549a45ccf19b23
2 changes: 1 addition & 1 deletion tests/index.test.ts
View file
Original file line number Diff line number Diff line change
@@ -110,7 +110,7 @@
pty = new Pty({
command: '/bin/cat',
onExit: () => {
vi.waitFor(() => expect(buffer.trim()).toBe(result.trim()));

Check failure on line 113 in tests/index.test.ts

GitHub Actions / Build and test on x86_64-unknown-linux-gnu

Unhandled error 

AssertionError: expected 'hello cat\r\nhello cat\r\nhello cat\r…' to be 'hello cat\r\nhello cat' // Object.is equality

- Expected
+ Received

  hello cat
+ hello cat
+ hello cat
  hello cat

 ❯ tests/index.test.ts:113:48

This error originated in "tests/index.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "can be resized". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.

Check failure on line 113 in tests/index.test.ts

GitHub Actions / Build and test on x86_64-unknown-linux-gnu

Unhandled error 

AssertionError: expected 'hello cat' to be 'hello cat\r\nhello cat' // Object.is equality

- Expected
+ Received

- hello cat
  hello cat

 ❯ tests/index.test.ts:113:48

This error originated in "tests/index.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "can be resized". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.

Check failure on line 113 in tests/index.test.ts

GitHub Actions / Build and test on x86_64-unknown-linux-gnu

Unhandled error 

AssertionError: expected 'hello cat' to be 'hello cat\r\nhello cat' // Object.is equality

- Expected
+ Received

- hello cat
  hello cat

 ❯ tests/index.test.ts:113:48
 ❯ Timeout.checkCallback [as _onTimeout] node_modules/vitest/dist/vendor/vi.YFlodzP_.js:3237:24
 ❯ listOnTimeout node:internal/timers:573:17
 ❯ processTimers node:internal/timers:514:7

This error originated in "tests/index.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "can be resized". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.

Check failure on line 113 in tests/index.test.ts

GitHub Actions / Build and test on x86_64-unknown-linux-gnu

Unhandled error 

AssertionError: expected 'hello cat\r\nhello cat\r\nhello cat' to be 'hello cat\r\nhello cat' // Object.is equality

- Expected
+ Received

  hello cat
+ hello cat
  hello cat

 ❯ tests/index.test.ts:113:48
 ❯ Timeout.checkCallback [as _onTimeout] node_modules/vitest/dist/vendor/vi.YFlodzP_.js:3237:24
 ❯ listOnTimeout node:internal/timers:573:17
 ❯ processTimers node:internal/timers:514:7

This error originated in "tests/index.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "can be resized". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.

Check failure on line 113 in tests/index.test.ts

GitHub Actions / Build and test on x86_64-unknown-linux-gnu

Unhandled error 

AssertionError: expected 'hello cat' to be 'hello cat\r\nhello cat' // Object.is equality

- Expected
+ Received

- hello cat
  hello cat

 ❯ tests/index.test.ts:113:48
 ❯ Timeout.checkCallback [as _onTimeout] node_modules/vitest/dist/vendor/vi.YFlodzP_.js:3237:24
 ❯ listOnTimeout node:internal/timers:573:17
 ❯ processTimers node:internal/timers:514:7

This error originated in "tests/index.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "can be resized". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.

Check failure on line 113 in tests/index.test.ts

GitHub Actions / Build and test on x86_64-unknown-linux-gnu

Unhandled error 

AssertionError: expected 'hello cat\r\nhello cat\r\nhello cat' to be 'hello cat\r\nhello cat' // Object.is equality

- Expected
+ Received

  hello cat
+ hello cat
  hello cat

 ❯ tests/index.test.ts:113:48
 ❯ Timeout.checkCallback [as _onTimeout] node_modules/vitest/dist/vendor/vi.YFlodzP_.js:3237:24
 ❯ listOnTimeout node:internal/timers:573:17
 ❯ processTimers node:internal/timers:514:7

This error originated in "tests/index.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "can be resized". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.

Check failure on line 113 in tests/index.test.ts

GitHub Actions / Build and test on x86_64-unknown-linux-gnu

Unhandled error 

AssertionError: expected 'hello cat' to be 'hello cat\r\nhello cat' // Object.is equality

- Expected
+ Received

- hello cat
  hello cat

 ❯ tests/index.test.ts:113:48
 ❯ Timeout.checkCallback [as _onTimeout] node_modules/vitest/dist/vendor/vi.YFlodzP_.js:3237:24
 ❯ listOnTimeout node:internal/timers:573:17
 ❯ processTimers node:internal/timers:514:7

This error originated in "tests/index.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "can be resized". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.

Check failure on line 113 in tests/index.test.ts

GitHub Actions / Build and test on x86_64-unknown-linux-gnu

Unhandled error 

AssertionError: expected 'hello cat\r\nhello cat\r\nhello cat\r…' to be 'hello cat\r\nhello cat' // Object.is equality

- Expected
+ Received

  hello cat
- hello cat
+ hello cat
+ hello cat
+ hello cat
+ 24 80

 ❯ tests/index.test.ts:113:48
 ❯ Timeout.checkCallback [as _onTimeout] node_modules/vitest/dist/vendor/vi.YFlodzP_.js:3237:24
 ❯ listOnTimeout node:internal/timers:573:17
 ❯ processTimers node:internal/timers:514:7

This error originated in "tests/index.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "can be resized". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.

Check failure on line 113 in tests/index.test.ts

GitHub Actions / Build and test on x86_64-unknown-linux-gnu

Unhandled error 

AssertionError: expected 'hello cat' to be 'hello cat\r\nhello cat' // Object.is equality

- Expected
+ Received

- hello cat
  hello cat

 ❯ tests/index.test.ts:113:48
 ❯ Timeout.checkCallback [as _onTimeout] node_modules/vitest/dist/vendor/vi.YFlodzP_.js:3237:24
 ❯ listOnTimeout node:internal/timers:573:17
 ❯ processTimers node:internal/timers:514:7

This error originated in "tests/index.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "can be resized". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
done();
},
});
@@ -142,7 +142,7 @@
buffer += data.toString();

if (buffer.includes('done1\r\n')) {
expect(buffer).toContain('24 80');

Check failure on line 145 in tests/index.test.ts

GitHub Actions / Build and test on x86_64-unknown-linux-gnu

Unhandled error 

AssertionError: expected '$ stty size; echo \'done1\'\r\ndone1\…' to contain '24 80'

- Expected
+ Received

- 24 80
+ $ stty size; echo 'done1'
+ done1
+ $ 

 ❯ ReadStream.<anonymous> tests/index.test.ts:145:24
 ❯ ReadStream.emit node:events:519:28
 ❯ FSReqCallback.wrapper [as oncomplete] node:fs:682:5

This error originated in "tests/index.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "can be resized". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
pty.resize({ rows: 60, cols: 100 });
buffer = '';

@@ -223,4 +223,4 @@
done();
}
}));
}, { repeats: 5 });
}, { repeats: 50 });