Add heartbeat to python client, and use a task manager to control background tasks #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenthebuilder
changed the title
jackyzha0
reviewed
Apr 17, 2024
| @@ -34,6 +35,7 @@ | |||
|
|
|||
| CROSIS_PREFIX_BYTES = b"\x00\x00" | |||
| PID2_PREFIX_BYTES = b"\xff\xff" | |||
| HEART_BEAT_INTERVAL_SECS = 2 | |||
There was a problem hiding this comment.
this should be configurable by the client/server
| @@ -148,7 +165,7 @@ async def _handle_messages(self) -> None: | |||
| handshake_request = ControlMessageHandshakeRequest( | |||
| type="HANDSHAKE_REQ", | |||
| protocolVersion="v1", | |||
| instanceId=self._instance_id, | |||
| instanceId=self._client_id, | |||
There was a problem hiding this comment.
hm we need both client and instance id
client is static, instance is random at startup
|
@zhenthebuilder Can this branch be deleted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added heartbeat
Use taskmanager to manage task
added CI