Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(support): improve dedup by using key #1661

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(support): improve dedup by using key #1661

wants to merge 1 commit into from

Conversation

DexterYan
Copy link
Member

@DexterYan DexterYan commented Oct 24, 2024 •
edited
Loading

Description, Motivation and Context

  • avoiding most JSON marshaling to check for duplicates, keep it for complicated one
  • use UniqKey

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@DexterYan DexterYan requested a review from a team as a code owner October 24, 2024 23:44
@DexterYan DexterYan added the type::feature New feature or request label Oct 24, 2024
@DexterYan DexterYan marked this pull request as draft October 25, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DexterYan