fix: make helm.SetValue more robust #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
sgalsaleh
reviewed
Feb 7, 2025
| @@ -58,7 +58,7 @@ func TestDefaultInstallation(t *testing.T) { | |||
| adminConsoleOpts := hcli.Calls[3].Arguments[1].(helm.InstallOptions) | |||
| assert.Equal(t, "admin-console", adminConsoleOpts.ReleaseName) | |||
| assertHelmValues(t, adminConsoleOpts.Values, map[string]interface{}{ | |||
| "kurlProxy.nodePort": int(30000), | |||
| "kurlProxy.nodePort": float64(30000), | |||
There was a problem hiding this comment.
runtimeconfig.AdminConsolePort() returns an int though. idk if that matters.
sgalsaleh
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Makes setting values mimic helm's --set-json argument.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?