Refactor match history elo view #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timche i am waiting your review, thanks |
|
@Panuchi it might be the case for a banned opponent or teammate, when ELO gets reverted by one or more matches. In other words, your elo got rolled back due to friend got banned in between those 2 matches |
It is clear that the reasons may be different, but still the extension must handle this case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation:
When you win, it happens that ELO is taken away, and it is not working in your extansion
How it works in your extension:
The ELO change for the match is not displayed
How it looks in my update:
P.S. I don’t know why the faceit was taken away ELO for the victory, although the person was top 2 in the team, perhaps the teammates sent reports.