Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sendTransaction arg type #642

Merged
merged 3 commits into from
Jul 17, 2024
Merged

fix: sendTransaction arg type #642

merged 3 commits into from
Jul 17, 2024

Conversation

KannuSingh
Copy link
Collaborator

Changed function argument to handle Hex data for value field on SafeSmartAccountLib.ts and SmartAccountLib.ts.
sendTransaction({ to, value, data }: { to: Address; value: bigint; data: Hex }) to
sendTransaction({ to, value, data }: { to: Address; value: bigint | Hex; data: Hex })

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
decentralized-relay-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 3:04pm
react-wallet-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 3:04pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
decentralized-relay-app ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 3:04pm
malicious-dapp-verify-simulation ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 3:04pm
react-auth-dapp ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 3:04pm
react-auth-wallet ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 3:04pm
react-dapp-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 3:04pm
react-dapp-v2-cosmos-provider ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 3:04pm
react-dapp-v2-with-ethers ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 3:04pm
react-dapp-v2-with-web3js ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 3:04pm
svelte-web3modal ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 3:04pm
vue-dapp-auth ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 3:04pm

@KannuSingh KannuSingh marked this pull request as ready for review July 17, 2024 15:16
@KannuSingh KannuSingh merged commit 48d7df3 into main Jul 17, 2024
19 checks passed
@KannuSingh KannuSingh deleted the fix-sendTransaction-call branch July 17, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants