Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dapp-v2] Display non-approved methods as disabled buttons instead of hiding entirely #220

Open
bkrem opened this issue Jul 4, 2023 · 0 comments
Open

[dapp-v2] Display non-approved methods as disabled buttons instead of hiding entirely #220

bkrem opened this issue Jul 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@bkrem
Copy link
Member

bkrem commented Jul 4, 2023

Context

  • The dapp now only displays buttons for optional methods that were approved by the wallet
  • This has led to some confusion around there seemingly only being personal_sign and eth_sendTransaction available, e.g. Add methods to example #219

Solution

  • Display all method buttons as before but disable the non-approved ones
  • Add a tooltip or helper text saying "not approved by wallet" or similar, for the disabled buttons
@bkrem bkrem added the enhancement New feature or request label Jul 4, 2023
@bkrem bkrem mentioned this issue Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bkrem