Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to example #219

Closed
finessevanes opened this issue Jul 3, 2023 · 1 comment
Closed

Add methods to example #219

finessevanes opened this issue Jul 3, 2023 · 1 comment

Comments

@finessevanes
Copy link
Contributor

Currently the example: https://react-app.walletconnect.com/ only had the following methods to test:

  • personal sign
  • send transaction

Add:

  • Sign typed data
  • Sign transaction
  • Send raw transaction
@bkrem
Copy link
Member

bkrem commented Jul 4, 2023

These methods are all still available, but the logic in the sample dapp now properly excludes them from the session if the wallet didn't approve them, since all except personal_sign and eth_sendTransaction are proposed as optional.

See e.g. Rainbow in the screenshot below which does approve the optionals.

I've added a follow-up issue #220 to make this clearer in the UI, closing in favour of that.

Screenshot 2023-07-04 at 10 37 19

@bkrem bkrem closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants