Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add balance to universal adapter #3182

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Nov 1, 2024

Description

  • Adds balance and account syncing for multi-chain base adapter

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Nov 1, 2024

⚠️ No Changeset found

Latest commit: b0c14f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 1:58pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 1:58pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 1:58pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 1:58pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 1:58pm

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 341.3% 4476 / 18701
🔵 Statements 341.3% 4476 / 18701
🔵 Functions 375.93% 371 / 1087
🔵 Branches 465.36000000000007% 679 / 1385
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/universal-adapter/client.ts 49.52% 46.55% 45.94% 49.52% 110-114, 132-133, 136, 141-142, 144-146, 155-159, 161-214, 227-229, 238-252, 268-284, 287-293, 295-301, 311-316, 319-323, 346-351, 355-360, 367-389, 395, 397-400, 406-434, 451-459, 487-488, 490, 495-496, 518-519, 531-540, 543-546, 550-578, 617-621, 626-629, 646-647, 659-684, 701-708
Generated in workflow #7173 for commit b0c14f6 by the Vitest Coverage Report Action

?.getCaipNetworks(caipNetwork.chainNamespace)
.find(network => network.id === caipNetwork.id)

// How to fetch balance on non-evm networks?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does Blockchain API not support non-evm? It should?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends on the chain, currently evm solana polkadot and I think btc since yesterday

@ganchoradkov ganchoradkov self-requested a review November 5, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants