-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wip: wcm equivalent in appkit #3177
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -2,6 +2,7 @@ import { CoreHelperUtil } from '@reown/appkit-core' | |||
import { AppKit } from '../src/client.js' | |||
import type { AppKitOptions } from '../src/utils/TypesUtil.js' | |||
import { PACKAGE_VERSION } from './constants.js' | |||
export { UniversalAdapterClient as UniversalAdapter } from '../src/universal-adapter/client.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already exported from @reown/appkit-adapters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find this package in the repo, is it typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right :( this one isnt, mb
Proper way would be to create a directoyry under packages/adapters/
that would expose this just as any other adapter instead of exporting from here.
Description
Please include a brief summary of the change.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist