Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override ens profile picture if ens domain is resolved #2916

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ignaciosantise
Copy link
Collaborator

Description

There's an issue then you resolve two ENS domains. if the second one doesn't have a profile picture, the sdk shows the previous picture.

Steps:

  1. Go to send flow, write vitalik.eth and wait til it resolves
  2. Go to preview send view and check the profile picture
  3. Go back and change the address to another domain that doesn't have a profile picture
  4. Go to preview send view and check the profile picture is still vitalik's picture

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 4d909ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@reown/appkit-scaffold-ui Patch
@apps/demo Patch
@apps/gallery Patch
@apps/laboratory Patch
@examples/html-ethers Patch
@examples/html-ethers5 Patch
@examples/html-wagmi Patch
@examples/next-ethers Patch
@examples/next-wagmi Patch
@examples/react-ethers Patch
@examples/react-ethers5 Patch
@examples/react-solana Patch
@examples/react-wagmi Patch
@examples/vue-ethers5 Patch
@examples/vue-solana Patch
@examples/vue-wagmi Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-ethers Patch
@reown/appkit-ethers5 Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-solana Patch
@reown/appkit-ui Patch
@reown/appkit-wagmi Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Sep 24, 2024 4:21pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 24, 2024 4:21pm

Copy link
Contributor

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 241.32999999999998% 4142 / 10385
🔵 Statements 241.32999999999998% 4142 / 10385
🔵 Functions 270.67% 321 / 801
🔵 Branches 312.08% 571 / 1045
File CoverageNo changed files found.
Generated in workflow #6289

Copy link
Contributor

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-BJTiG_hk.js 1867.015 532.954
assets/index.js 9.63 3.161
assets/index2.js 11.572 3.199
assets/w3m-modal.js 7.397 2.616
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.328
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.237
Total Size 2411.76 698.265

Base Size

Name Size (kb) Gzip (kb)
assets/index-BJTiG_hk.js 1867.015 532.954
assets/index.js 9.63 3.161
assets/index2.js 11.572 3.199
assets/w3m-modal.js 7.397 2.616
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.328
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.237
Total Size 2411.76 698.265

@ignaciosantise ignaciosantise changed the title fix: fix: override ens profile picture if ens domain is resolved fix: override ens profile picture if ens domain is resolved Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants