Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add connect proxy error event #2911

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Sep 24, 2024

Description

Adds error event message when there is an issue while parsing the deeplink URL in w3m-connecting-wc-mobile component.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Sep 24, 2024

⚠️ No Changeset found

Latest commit: eec2a1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Sep 24, 2024 0:06am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 24, 2024 0:06am

Copy link
Contributor

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 241.32999999999998% 4142 / 10385
🔵 Statements 241.32999999999998% 4142 / 10385
🔵 Functions 270.67% 321 / 801
🔵 Branches 312.08% 571 / 1045
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/core/src/utils/TypeUtil.ts 100% 100% 100% 100%
Generated in workflow #6280

Copy link
Contributor

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-B0DFLacx.js 1867.01 532.954
assets/index.js 9.63 3.16
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.397 2.614
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.236
Total Size 2411.755 698.258

Base Size

Name Size (kb) Gzip (kb)
assets/index-B0DFLacx.js 1867.01 532.954
assets/index.js 9.63 3.16
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.397 2.614
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.236
Total Size 2411.755 698.258

@enesozturk enesozturk merged commit 2f4a764 into main Sep 24, 2024
17 checks passed
@enesozturk enesozturk deleted the refactor/add-deeplink-parse-error-event branch September 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants