Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non announced connectors filtered as repeated #2907

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Sep 23, 2024

Description

  • Non-announced connectors were being filtered as duplicates even when they are not present on the screen in the first place.
  • Adds fix to only filter announced/injected connectors

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1072

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Sep 23, 2024 5:28pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 23, 2024 5:28pm

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: edcdfb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@reown/appkit-scaffold-ui Patch
@apps/demo Patch
@apps/gallery Patch
@apps/laboratory Patch
@examples/html-ethers Patch
@examples/html-ethers5 Patch
@examples/html-wagmi Patch
@examples/next-ethers Patch
@examples/next-wagmi Patch
@examples/react-ethers Patch
@examples/react-ethers5 Patch
@examples/react-solana Patch
@examples/react-wagmi Patch
@examples/vue-ethers5 Patch
@examples/vue-solana Patch
@examples/vue-wagmi Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-ethers Patch
@reown/appkit-ethers5 Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-solana Patch
@reown/appkit-ui Patch
@reown/appkit-wagmi Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 240.17999999999998% 4137 / 10403
🔵 Statements 240.17999999999998% 4137 / 10403
🔵 Functions 269.68% 322 / 805
🔵 Branches 311.65% 568 / 1041
File CoverageNo changed files found.
Generated in workflow #6268

Copy link
Contributor

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-CP83LioO.js 1866.997 532.923
assets/index.js 9.63 3.163
assets/index2.js 11.572 3.197
assets/w3m-modal.js 7.397 2.615
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.589
index.html 0.329 0.238
Total Size 2411.742 698.23

Base Size

Name Size (kb) Gzip (kb)
assets/index-CP83LioO.js 1866.997 532.923
assets/index.js 9.63 3.163
assets/index2.js 11.572 3.197
assets/w3m-modal.js 7.397 2.615
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.589
index.html 0.329 0.238
Total Size 2411.742 698.23

@tomiir tomiir merged commit b35af73 into main Sep 23, 2024
17 checks passed
@tomiir tomiir deleted the fix/coinbase-not-showing branch September 23, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants