fix: approved caip networks data for universal provider #2872
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: db27a61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
| approvedCaipNetworkIds: data?.approvedCaipNetworkIds, | ||
| supportsAllNetworks: data?.supportsAllNetworks | ||
| }) | ||
| const networkControllerClient = ChainController.getNetworkControllerClient() |
There was a problem hiding this comment.
This will only get the active namespace's networkControllerClient. Do we need to set data for other adapter's at the same?
There was a problem hiding this comment.
I did not understand the question. Is it something extra we need to implement? These changes are only cleaning up the code, there is no logic change here
| } | ||
| } | ||
| } | ||
| RouterController.push('SwitchNetwork', { ...routerData, network }) |
There was a problem hiding this comment.
What about the other cases? Like multiple adapter flows (SwitchActiveChain)? or ConnectingWalletConnect case? I don't see the other cases handled in the SwitchNetwork view
There was a problem hiding this comment.
I'm still in progress with that, this was one attempt to clean up the logic because I could not figure out what was intended to happen here. But I'll jam more over to get it sorted.
apps/laboratory/tests/wallet.spec.ts
Outdated
| if (library === 'solana') { | ||
| // Solana doesn't have disabled networks | ||
| return | ||
| } |
There was a problem hiding this comment.
We have a solanaUnsupported chain do we not?
Description
This PR is adding the logic to verify the available networks when connecting through Universal Provider.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist