Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change configs to use main and V5 #2408

Merged
merged 6 commits into from
Jun 12, 2024
Merged

chore: change configs to use main and V5 #2408

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6813309
chore: change configs to use main and V5
tomiir Jun 12, 2024
a667d26
Merge branch 'main' into fix/setup-v5-main-ci
tomiir Jun 12, 2024
a44d432
chore: set changesets config to main
tomiir Jun 12, 2024
17c30c8
fix: set canary to main
tomiir Jun 12, 2024
4dd6ffd
Merge branch 'fix/setup-v5-main-ci' of github.com:WalletConnect/web3m…
tomiir Jun 12, 2024
5114156
fix: set default for workflow call to main
tomiir Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"fixed": [],
"linked": [],
"access": "public",
"baseBranch": "V4",
"baseBranch": "V5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/changesets/changesets/blob/main/docs/config-file-options.md#basebranch-git-branch-name

Will move to main

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, this should only be used on releases so it's correct to point to V5

"updateInternalDependencies": "patch",
"ignore": []
}
2 changes: 2 additions & 0 deletions .github/workflows/pr_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
branches:
- V3
- V4
- V5
- main

concurrency:
# Support push/pr as event types with different behaviors each:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_dispatch:
push:
branches:
- V4
- V5

concurrency: ${{ github.workflow }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Release
on:
push:
branches:
- V4
- V5

concurrency: ${{ github.workflow }}-${{ github.ref }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ui_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
inputs:
branch:
description: 'The branch to use'
default: 'V3'
default: 'V5'
required: false
type: string
base-url:
Expand Down
Loading